ondemand icon indicating copy to clipboard operation
ondemand copied to clipboard

support for symlinks in project templates

Open johrstrom opened this issue 1 year ago • 1 comments

From discourse - https://discourse.openondemand.org/t/job-templates-allow-for-symlinkd-script-resource/3369

The gist of the idea is that you have a template that users can copy over and in that template is a symlink to some other shell script. When copying the template, we should make a symlink to that original shell script for use in the launchers.

johrstrom avatar Jun 25 '24 15:06 johrstrom

I have to admit here that I don't know if we should make a new symlink. It seems like we shouldn't because that original file isn't editable. So instead of making a symlink, we should probably copy the original file itself. That way they get the default shell script the admin wants to distribute, but since it's a real file, the user can edit it after the fact.

johrstrom avatar Jun 25 '24 15:06 johrstrom

I have to admit here that I don't know if we should make a new symlink.

Re-reading the discourse this is the exact behavior the user wants to avoid. So even though I think (thought?) we should make a copy, the original poster wanted to preserve the symlink. Though I may have to re-read the discourse topic a few more times to be extra sure.

johrstrom avatar Aug 19 '25 18:08 johrstrom

Review notes: Explained the issue is about preserving symlinks when copying templates Asked for clarification on why this matters Clarified it's about whether to copy the actual file or maintain the symlink Team agreed it's a small detail but worth addressing eventually

moffatsadeghi avatar Aug 20 '25 18:08 moffatsadeghi