dynamico icon indicating copy to clipboard operation
dynamico copied to clipboard

Add DependenciesProvider

Open nataly87s opened this issue 6 years ago • 7 comments

related to #87

nataly87s avatar Jan 17 '20 19:01 nataly87s

nice change. I think that the most important thing here is changing the prefix for the overriding client's cache. I'll talk to @EladBezalel and we'll try to challenge this solution to see that everything works fine. In the meantime can you please check the the example project works the same? I think you did not break any API but just to be sure.

eladav avatar Jan 19 '20 15:01 eladav

@eladav example project works the same

nataly87s avatar Jan 21 '20 20:01 nataly87s

@eladav @EladBezalel what's up? any comments? requests? something?

nataly87s avatar Jan 28 '20 21:01 nataly87s

@nataly87s sorry for the delay...looking at both PRs now.

eladav avatar Jan 30 '20 08:01 eladav

So the reason we're having a hard time with this change is more conceptual than code-wise. The implementation looks 💯. It looks like you want to be able to show a dynamic component from within a dynamic component. Given that you're going to use work spaces it must be quite easy to just bundle the host component along with the displayed component instead of having another client and another host-id which might make it harder for you to realize which component is shown at what configuration.

If you worry about dependencies and bundle size it might still be easier to bundle the child component along with the host component as it already has the required dependencies.

Am I missing something? wdyt?

@EladBezalel feel free to chime in if you're available 🤔

eladav avatar Jan 30 '20 09:01 eladav

@eladav I want to have an app with as few dependencies as possible, and a dynamic component that will inject all the other dependecies, so that if I want to update a package I won't have to publish a new version of the app, just a new version of the main component. The app will only have native dependencies along with react and dynamico.

nataly87s avatar Jan 30 '20 13:01 nataly87s

@eladav @EladBezalel sup?

nataly87s avatar Feb 14 '20 19:02 nataly87s