DataFed icon indicating copy to clipboard operation
DataFed copied to clipboard
verified publisher icon ORNL

Change ACLUpdateRequest to use ACLRule

Open dvstans opened this issue 4 years ago • 2 comments

The ACL update message uses a JSON string payload for rules - this should be changed to use the existing ACLRule structure.

dvstans avatar Jul 06 '21 13:07 dvstans

Clarification

Where is the existing ACLRule structure defined if it is not JSON?

JoshuaSBrown avatar Dec 27 '22 20:12 JoshuaSBrown

There is an ACLRule message type defined in the SDMS.proto file (used to return ACLs for display), but the ACLUpdateRequest message just takes JSON. It should specify an array of ACLRule sub-documents. None of this matters if we refactor away from protobuf though.

dvstans avatar Jan 26 '23 14:01 dvstans