DataFed
DataFed copied to clipboard
[DAPS-1408] Provenance Visual Management Lint (1/2)
PR Description
- Move files over + lint
- Move out common svgs
Tasks
Summary by Sourcery
Restructure provenance visualization code by migrating panel_graph and related files into a dedicated components directory, centralizing common SVG arrow marker definitions, and updating import paths and static references.
Enhancements:
- Relocate panel_graph.js and related assets under web/static/components/provenance
- Extract arrow marker SVG definitions into a shared assets module
- Update import paths and main view script references to the new component paths
- Add CSS link for provenance graph styles in the main template
Reviewer's Guide
This PR reorganizes the Provenance panel code by moving files into a dedicated components directory, extracting common SVG arrow-marker functions into a shared asset module, and updating the main view to reference the new script and style locations.
File-Level Changes
| Change | Details | Files |
|---|---|---|
| Reorganized provenance panel module and adjusted import paths |
|
web/static/panel_graph.jsweb/static/components/provenance/panel_graph.js |
| Extracted SVG arrow-marker definitions into shared asset module |
|
web/static/components/provenance/assets/arrow-markers.jsweb/static/components/provenance/panel_graph.js |
| Updated view references for relocated assets |
|
web/views/main.ect |
Tips and commands
Interacting with Sourcery
-
Trigger a new review: Comment
@sourcery-ai reviewon the pull request. - Continue discussions: Reply directly to Sourcery's review comments.
-
Generate a GitHub issue from a review comment: Ask Sourcery to create an
issue from a review comment by replying to it. You can also reply to a
review comment with
@sourcery-ai issueto create an issue from it. -
Generate a pull request title: Write
@sourcery-aianywhere in the pull request title to generate a title at any time. You can also comment@sourcery-ai titleon the pull request to (re-)generate the title at any time. -
Generate a pull request summary: Write
@sourcery-ai summaryanywhere in the pull request body to generate a PR summary at any time exactly where you want it. You can also comment@sourcery-ai summaryon the pull request to (re-)generate the summary at any time. -
Generate reviewer's guide: Comment
@sourcery-ai guideon the pull request to (re-)generate the reviewer's guide at any time. -
Resolve all Sourcery comments: Comment
@sourcery-ai resolveon the pull request to resolve all Sourcery comments. Useful if you've already addressed all the comments and don't want to see them anymore. -
Dismiss all Sourcery reviews: Comment
@sourcery-ai dismisson the pull request to dismiss all existing Sourcery reviews. Especially useful if you want to start fresh with a new review - don't forget to comment@sourcery-ai reviewto trigger a new review!
Customizing Your Experience
Access your dashboard to:
- Enable or disable review features such as the Sourcery-generated pull request summary, the reviewer's guide, and others.
- Change the review language.
- Add, remove or edit custom review instructions.
- Adjust other review settings.
Getting Help
- Contact our support team for questions or feedback.
- Visit our documentation for detailed guides and information.
- Keep in touch with the Sourcery team by following us on X/Twitter, LinkedIn or GitHub.