DataFed icon indicating copy to clipboard operation
DataFed copied to clipboard

Individual docker scripts ci changes

Open nedvedba opened this issue 1 year ago • 1 comments

Summary by Sourcery

Refactor CI configuration to utilize new script-based Docker container management, enhancing maintainability and reducing inline script complexity.

CI:

  • Refactor CI scripts to use new container script generation for core, web, repo, and GCS components, replacing inline Docker run commands with script-based execution.

nedvedba avatar Sep 11 '24 18:09 nedvedba

Reviewer's Guide by Sourcery

This pull request refactors the CI/CD pipeline for Docker container deployment, introducing new scripts for generating and managing container scripts for the metadata server, repository server, and GCS (Globus Connect Server). The changes aim to improve modularity, reduce redundancy, and enhance the maintainability of the deployment process.

File-Level Changes

Change Details Files
Refactored Docker container deployment scripts
  • Removed inline Docker run commands and replaced them with calls to generated scripts
  • Added new script 'generate_metadata_container_scripts.sh' to create Docker run scripts for core and web containers
  • Added new script 'generate_repo_container_scripts.sh' to create Docker run scripts for repository and GCS containers
  • Introduced scripts for creating and removing a Docker network for DataFed containers
  • Added scripts for running, stopping, and removing individual containers (core, web, nginx, repo, gcs)
.gitlab/end_to_end.yml
scripts/generate_metadata_container_scripts.sh
scripts/generate_repo_container_scripts.sh
Updated database configuration in generate_datafed.sh
  • Added support for configurable database port
  • Set default database port to 8529 if not specified
scripts/generate_datafed.sh
Improved CI/CD pipeline configuration
  • Removed 'generate_datafed.sh' call from CI/CD stages
  • Added calls to new container management scripts in CI/CD stages
  • Updated environment variable handling for container deployment
.gitlab/end_to_end.yml

Tips
  • Trigger a new Sourcery review by commenting @sourcery-ai review on the pull request.
  • Continue your discussion with Sourcery by replying directly to review comments.
  • You can change your review settings at any time by accessing your dashboard:
    • Enable or disable the Sourcery-generated pull request summary or reviewer's guide;
    • Change the review language;
  • You can always contact us if you have any questions or feedback.

sourcery-ai[bot] avatar Sep 11 '24 18:09 sourcery-ai[bot]