AMO-Tools-Desktop icon indicating copy to clipboard operation
AMO-Tools-Desktop copied to clipboard

Pump/Fan Curve intersection accuracy

Open nbintertech opened this issue 3 years ago • 5 comments

Intersections are still being approximated. This is because there is not always a coordinate pair created for the actual intersection that is calculated. Maybe there is a way to take the regression curve equation and mathematically produce the intersection from that?

  • Baseline intersection finds the two coordinates bookending where the intersection would be, and sums them, taking the average to get the intersection.
    Lines 398-443 in the below file. calculateBaselineIntersectionPoint() https://github.com/ORNL-AMO/AMO-Tools-Desktop/blob/develop/src/app/calculator/system-and-equipment-curve/system-and-equipment-curve.service.ts

  • Modification intersection - Iterate over all coordinate pairs, calculating distance for each, taking the shortest distance, finding those points, and summing/averaging the coordinate pairs for greater accuracy. lines 74-107 calculateModificationIntersectionPoint() https://github.com/ORNL-AMO/AMO-Tools-Desktop/blob/develop/src/app/calculator/system-and-equipment-curve/system-and-equipment-curve-graph/system-and-equipment-curve-graph.service.ts

nbintertech avatar Sep 23 '20 11:09 nbintertech