opm-simulators icon indicating copy to clipboard operation
opm-simulators copied to clipboard

dont call beginTimeStep when restarting simulation after failing

Open totto82 opened this issue 9 months ago • 1 comments

We do not want to redo the well testing, the pre-solving of wells, gas-lift optimization, network balancing, etc, after failed simulations

For now, this PR adds an if around the outer beginTimeStep. We may need a more fine-grained approach. However, initial testing on selected models is promising.

totto82 avatar Mar 28 '25 14:03 totto82

jenkins build this please

totto82 avatar Mar 28 '25 14:03 totto82

jenkins build this failure_report please

totto82 avatar Mar 31 '25 06:03 totto82

jenkins build this failure_report please

totto82 avatar Mar 31 '25 10:03 totto82

jenkins build this failure_report please

totto82 avatar Mar 31 '25 12:03 totto82

jenkins build this failure_report please

totto82 avatar Apr 01 '25 08:04 totto82

jenkins build this failure_report please

totto82 avatar Apr 01 '25 10:04 totto82

jenkins build this failure_report please

totto82 avatar Apr 02 '25 11:04 totto82

jenkins build this failure_report please

totto82 avatar Apr 02 '25 12:04 totto82

jenkins build this failure_report please

It doesn't show up in the failure report, so just in case you didn't see it, the MSW_2D_VERT_02 test does not complete and times out (1500 seconds, 25 minutes maximum runtime). The transcript suggests that the well solution fails at some point, but someone who knows this part of the code better than I will need to analyse the underlying problem.

bska avatar Apr 02 '25 13:04 bska

jenkins build this failure_report please

It doesn't show up in the failure report, so just in case you didn't see it, the MSW_2D_VERT_02 test does not complete and times out (1500 seconds, 25 minutes maximum runtime). The transcript suggests that the well solution fails at some point, but someone who knows this part of the code better than I will need to analyse the underlying problem.

It looks like MSW_2D_VERT_02 got problem at the first time step with singular matrix,

https://ci.opm-project.org/job/opm-simulators-PR-builder/7783/testReport/junit/(root)/mpi/compareECLFiles_flow_MSW_2D_VERT_02/

GitPaean avatar Apr 02 '25 13:04 GitPaean

It doesn't show up in the failure report, so just in case you didn't see it, the MSW_2D_VERT_02

Thanks for letting me know. I didn't notice this. I will investigate and report back.

totto82 avatar Apr 02 '25 14:04 totto82

jenkins build this failure_report please

totto82 avatar Apr 03 '25 14:04 totto82

jenkins build this failure_report please

totto82 avatar Apr 03 '25 18:04 totto82

jenkins build this failure_report please

totto82 avatar Apr 07 '25 08:04 totto82

jenkins build this failure_report please

totto82 avatar Apr 14 '25 08:04 totto82

jenkins build this failure_report please

GitPaean avatar Apr 24 '25 09:04 GitPaean

a rebase is needed for this PR.

GitPaean avatar Apr 24 '25 09:04 GitPaean

jenkins build this failure_report please

totto82 avatar Apr 24 '25 13:04 totto82

jenkins build this failure_report please

totto82 avatar Apr 25 '25 11:04 totto82

jenkins build this failure_report please

totto82 avatar Apr 30 '25 10:04 totto82

jenkins build this failure_report please

totto82 avatar Jun 03 '25 09:06 totto82