opm-simulators icon indicating copy to clipboard operation
opm-simulators copied to clipboard

Trigger WELSPECS Report From Simulator Side

Open bska opened this issue 9 months ago • 1 comments

This achieves two goals

  1. It ensures proper sequencing with respect to other PRT file reports.
  2. It simplifies generating WELSPECS reports in restarted simulation runs.

bska avatar Mar 25 '25 16:03 bska

This PR depends on changes in the upstream PR OPM/opm-common#4539. I will keep the PR in a draft state until such time as it is ready for review and merging.

bska avatar Mar 25 '25 16:03 bska

Tested in Equinor. Results are good and looking forward to seeing this go into master.

tskille avatar Apr 01 '25 07:04 tskille

Tested in Equinor. Results are good and looking forward to seeing this go into master.

Thank you for testing–this is greatly appreciated!

bska avatar Apr 01 '25 07:04 bska

The requisite earlier PRs have all been merged into the master branch so I'm marking this as ready for review. Recall that it needs the upstream companion PR OPM/opm-common#4539 to work.

bska avatar Apr 03 '25 11:04 bska

jenkins build this opm-common=4539 please

bska avatar Apr 03 '25 11:04 bska

jenkins build this opm-common=4539 please

bska avatar Apr 03 '25 14:04 bska

PR approved and build check is green. I'll merge into master.

bska avatar Apr 03 '25 15:04 bska