opm-simulators icon indicating copy to clipboard operation
opm-simulators copied to clipboard
verified publisher icon OPM

Actually respect NUPCOL (not NUPCOL+1) and allow network to converge with GLO

Open vkip opened this issue 9 months ago • 2 comments

Also:

  • Some more informative output in case network does not converge
  • Change order of return arguments in updateWellControlsAndNetworkIteration to be consistent with updateWellControls

vkip avatar Mar 21 '25 12:03 vkip

jenkins build this failure_report please

vkip avatar Mar 21 '25 12:03 vkip

Note. I have a PR where this code is refactored. https://github.com/OPM/opm-simulators/pull/6095 The refactoring also contains more info if the network does not converge.

totto82 avatar Mar 21 '25 13:03 totto82

jenkins build this failure_report please

totto82 avatar Apr 02 '25 06:04 totto82

Test failures are mainly due to different time-stepping. I've been through all the failed tests with shorter time-steps and find results to be (visually) identical to master, except for two tests that differ in a single time-step - these become identical to master when using NUPCOL=11.

vkip avatar Apr 02 '25 10:04 vkip

Thanks for looking into the test failures. I will start the process of updating the reference results and merging this.

totto82 avatar Apr 02 '25 11:04 totto82

jenkins build this update_data please

totto82 avatar Apr 02 '25 11:04 totto82

jenkins build this opm-tests=1322 please

totto82 avatar Apr 02 '25 12:04 totto82