opm-simulators icon indicating copy to clipboard operation
opm-simulators copied to clipboard
verified publisher icon OPM

Time step rejection if tolerance test fails

Open erikhide opened this issue 10 months ago • 1 comments

I've implemented rejection of a completed time step if the relative change is larger than the time step control tolerance (only for the general 3rd order controller). The code seems to work as it should, but I might have missed something, so please let me know if you find anything wrong.

An earlier version of this can be found in #5317, but the current one is up to date with the current master.

erikhide avatar Feb 18 '25 16:02 erikhide

jenkins build this please

bska avatar Feb 20 '25 15:02 bska

jenkins build this please

atgeirr avatar May 09 '25 12:05 atgeirr

I do not see an obvious reason for the segfaults in the tests. In fact, I expected no test failures at all! I think the best is to investigate this in a debugger to see why it faults. Give me a hint if you need help.

atgeirr avatar May 09 '25 15:05 atgeirr

jenkins build this please

atgeirr avatar May 13 '25 11:05 atgeirr

jenkins build this please

atgeirr avatar May 14 '25 09:05 atgeirr

jenkins build this please

atgeirr avatar May 14 '25 11:05 atgeirr

this contains a merge commit. please rebase on master.

akva2 avatar May 14 '25 11:05 akva2

please rebase on master.

Done!

erikhide avatar May 14 '25 11:05 erikhide

jenkins build this please

akva2 avatar May 14 '25 11:05 akva2

Thanks, merging!

Please edit the PR description to add a few sentences of description for the manual.

atgeirr avatar May 14 '25 12:05 atgeirr