opm-simulators icon indicating copy to clipboard operation
opm-simulators copied to clipboard

Add optional iterations in the group switching algorithm

Open totto82 opened this issue 10 months ago • 3 comments

Default is 1 i.e. it will only check once.

totto82 avatar Jan 30 '25 13:01 totto82

This if first part of https://github.com/OPM/opm-simulators/pull/5607

totto82 avatar Jan 30 '25 13:01 totto82

jenkins build this please

totto82 avatar Jan 30 '25 13:01 totto82

mind the warning(s).

akva2 avatar Jan 30 '25 14:01 akva2

jenkins build this please

totto82 avatar Apr 28 '25 12:04 totto82

This can be merged as is. But we should also factor out the network part and remove any well solve from updateWellStateWithTarget before considering using this feature. I will make another PR where the network part is refactored to a separate call asap.

totto82 avatar Apr 28 '25 12:04 totto82

jenkins build this please

totto82 avatar May 06 '25 13:05 totto82

jenkins build this please

totto82 avatar May 08 '25 10:05 totto82

Since default is 1 it should be safe to merge this as is. More testing is needed if we want to change the default.

totto82 avatar May 08 '25 14:05 totto82

Thanks for the invitation for review. I will review this later today or tomorrow. I am aware that the PR does not change results by default, while I would like to check the code itself.

GitPaean avatar May 12 '25 10:05 GitPaean

Hei, the code change looks straightforward, I think this is towards the good directions, which hopefully make sure the well controls are settled for each iteration before we go ahead to assemble.

From the testing side, do you find this helps any specific case and what is your observation, thanks.

GitPaean avatar May 13 '25 08:05 GitPaean

jenkins build this please

totto82 avatar May 14 '25 07:05 totto82

Thanks for the update. It looks good to me. I am merging it to make easier for people to test.

GitPaean avatar May 14 '25 12:05 GitPaean