opm-simulators icon indicating copy to clipboard operation
opm-simulators copied to clipboard

Set correct target iterations in SimpleIterationTimestepControl

Open jakobtorben opened this issue 1 year ago • 2 comments

For the simple iteration timestep controller, used for both the "iterationcount" and "newtoniterationcount" timestep controller, we are currently subtracting 1 from the target iterations. This is not correct and is misleading from the time-step-control-target-newton-iterations option. For example, if one set the target to 2 Newton iterations, which works well for NLDD, the timestep will not change.

jakobtorben avatar Jul 11 '24 11:07 jakobtorben

jenkins build this please

bska avatar Jul 11 '24 11:07 bska

This should be merged, but I do not understand the regression failure here. The DAY field should be no more than 20 since October 20 is the final day of the case, yet we see 28 in the summary. And the simulation output also ends on the 20th.

atgeirr avatar Jul 19 '24 07:07 atgeirr

jenkins build this please

jakobtorben avatar Sep 12 '24 08:09 jakobtorben

@atgeirr Now the regression tests pass

jakobtorben avatar Sep 12 '24 08:09 jakobtorben