opm-simulators Support instantaneous flow rates in extended network (WEFAC and GEFAC item 3)

Needs https://github.com/OPM/opm-common/pull/4094

Jun 05 '24 07:06 vkip

jenkins build this opm-common=4094 please

Jun 05 '24 09:06 vkip

Please give a hint when the update is finished with this PR. And maybe @bska can have a look at the changes related to KeywordValidition and FullySupportedFlowKeywords?

Jun 27 '24 07:06 GitPaean

Please give a hint when the update is finished with this PR. And maybe @bska can have a look at the changes related to KeywordValidition and FullySupportedFlowKeywords?

Will do, placing this and the companion in opm-common in draft for now.

Jun 28 '24 09:06 vkip

Plan to rebase on https://github.com/OPM/opm-simulators/pull/5866

Jan 13 '25 14:01 vkip

Now contains 5866 for testing - will rebase once that is merged.

Jan 17 '25 15:01 vkip

jenkins build this opm-common=4094 please

Feb 06 '25 16:02 vkip

With https://github.com/OPM/opm-tests/pull/1175 merged, I think we can have a regression test with it. It can go in with this PR or go in with a separate following up PR.

Feb 12 '25 21:02 GitPaean

It looks correct to me. Assuming the results have been verified and I only left a few minor comments.

Thank you for the review, will update now. I agree that we should add the test, but let's do that in a follow-up PR.

Feb 14 '25 09:02 vkip

jenkins build this opm-common=4094 please

Feb 14 '25 11:02 vkip

Thanks for the update. The upstream PR https://github.com/OPM/opm-common/pull/4094 has been merged. I am also getting this PR in now.

Feb 14 '25 13:02 GitPaean