opm-simulators icon indicating copy to clipboard operation
opm-simulators copied to clipboard

Bugfix: initialize the input temperature in restart run without temperature in the restart file

Open totto82 opened this issue 1 year ago • 3 comments

The issue is related to restart of cases using CO2STORE

totto82 avatar May 03 '24 10:05 totto82

jenkins build this please

totto82 avatar May 03 '24 10:05 totto82

I don't think I understand what problem this is trying to solve. If we're restarting a run and there is no temperature information in the restart file, then does that not mean that it's an isothermal run? If so, why do we need temperature data?

For CO2STORE you will need the initial temperature in the reservoir. We used to store it in the restart files, but that was removed since it is constant in isothermal runs.

totto82 avatar May 03 '24 11:05 totto82

I don't think I understand what problem this is trying to solve. If we're restarting a run and there is no temperature information in the restart file, then does that not mean that it's an isothermal run? If so, why do we need temperature data?

For CO2STORE you will need the initial temperature in the reservoir. We used to store it in the restart files, but that was removed since it is constant in isothermal runs.

Ah, okay. Then I think

  1. This should be contingent on CO2STORE being active
  2. The temperature initialisation itself should be in a separate function which is only invoked for CO2STORE, and only if temperature information is not already loaded from the restart file.

As currently written, I think the risk of confusion is too great.

bska avatar May 03 '24 11:05 bska

jenkins build this please

totto82 avatar May 06 '24 08:05 totto82