opm-simulators icon indicating copy to clipboard operation
opm-simulators copied to clipboard
verified publisher icon OPM

Remove check for active wells for drift compensation

Open totto82 opened this issue 1 year ago • 3 comments

Well is active condition for drift compensation was added some time ago due to convergence issues for a case without any dynamics. For CO2 injection simulation the drift compensation is still beneficial even when wells are no longer active. An alternative to this PR is to add a parameter like onlyEnableDriftCompensationWhenWellsAreActive, but I would rather just disable driftCompensation for these cases completely.

totto82 avatar Jan 19 '24 08:01 totto82

jenkins build this please

totto82 avatar Jan 19 '24 08:01 totto82

I think we should check the original motivating case before merging this.

atgeirr avatar Jan 19 '24 08:01 atgeirr

I think we should check the original motivating case before merging this.

I am working on it.

totto82 avatar Jan 19 '24 08:01 totto82

jenkins build this please

totto82 avatar Aug 19 '24 10:08 totto82

I think we should check the original motivating case before merging this.

The original motivation is gone since drift is no longer default. I suggest merging this when green.

totto82 avatar Aug 19 '24 10:08 totto82