opm-simulators icon indicating copy to clipboard operation
opm-simulators copied to clipboard

Use min timestep from TUNING also when updating (not only initially)

Open vkip opened this issue 2 years ago • 6 comments

(+ using the right value, TSMINZ, initially). Together with https://github.com/OPM/opm-common/pull/3740, should eliminate side effects of --enable-tuning=true when there is no TUNING record or non-default TUNING record items.

vkip avatar Oct 31 '23 10:10 vkip

jenkins build this opm-common=3740 please

vkip avatar Oct 31 '23 10:10 vkip

Test failures apparently due to changing the default value of minimum time step to coincide with the Flow default (i.e., without --enable-tuning=true). [Value is written to DOUBHEAD in the .INIT file.]

vkip avatar Oct 31 '23 12:10 vkip

jenkins build this opm-common=3740 please

vkip avatar Nov 16 '23 11:11 vkip

@vkip Should this still be reviewed and merged or is this resolved in another way already?

blattms avatar Mar 08 '24 16:03 blattms

@vkip Should this still be reviewed and merged or is this resolved in another way already?

To my knowledge this is not yet resolved.

vkip avatar Mar 11 '24 09:03 vkip

Or actually, using the min timestep you maybe fixed when working on NEXTSTEP? If so the only relevant thing here might be the changed message (getting the correct value in days).

vkip avatar Mar 11 '24 09:03 vkip