opm-simulators icon indicating copy to clipboard operation
opm-simulators copied to clipboard

change default well operability iter to true

Open totto82 opened this issue 2 years ago • 9 comments

totto82 avatar Jun 06 '23 13:06 totto82

jenkins build this please

totto82 avatar Jun 06 '23 13:06 totto82

benchmark please

GitPaean avatar Jun 06 '23 13:06 GitPaean

Benchmark result overview:

Test Configuration Relative
opm-git OPM Benchmark: drogon - Threads: 1 0.993
opm-git OPM Benchmark: drogon - Threads: 8 1.167
opm-git OPM Benchmark: smeaheia - Threads: 1 1
opm-git OPM Benchmark: smeaheia - Threads: 8 1
opm-git OPM Benchmark: spe10_model_1 - Threads: 1 1.074
opm-git OPM Benchmark: spe10_model_1 - Threads: 8 1.091
opm-git OPM Benchmark: flow_mpi_extra - Threads: 1 0.988
opm-git OPM Benchmark: flow_mpi_extra - Threads: 8 1.158
opm-git OPM Benchmark: flow_mpi_norne - Threads: 1 0.982
opm-git OPM Benchmark: flow_mpi_norne - Threads: 8 1.017
  • Speed-up = Total time master / Total time pull request. Above 1.0 is an improvement. *

FAILED RUNS: OPM Benchmark: punqs3 - Threads: 1 - 2023-06-06 Master Reference: The test run did not produce a result. E: Error: Unrecoverable errors while loading input: Problem with keyword OPM Benchmark: punqs3 - Threads: 1 - opm-simulators 4689: change default well operability iter to true: The test run did not produce a result. E: Error: Unrecoverable errors while loading input: Problem with keyword OPM Benchmark: punqs3 - Threads: 8 - 2023-06-06 Master Reference: The test run did not produce a result. E: Error: Unrecoverable errors while loading input: Problem with keyword OPM Benchmark: punqs3 - Threads: 8 - opm-simulators 4689: change default well operability iter to true: The test run did not produce a result. E: Error: Unrecoverable errors while loading input: Problem with keyword OPM Benchmark: smeaheia - Threads: 1 - 2023-06-06 Master Reference: The test run did not produce a result. E: mpirun was unable to launch the specified application as it could not access OPM Benchmark: smeaheia - Threads: 8 - 2023-06-06 Master Reference: The test run did not produce a result. E: mpirun was unable to launch the specified application as it could not access OPM Benchmark: flow_mpi_norne_4c_msw - Threads: 1 - 2023-06-06 Master Reference: The test run did not produce a result. E: Error: Unrecoverable errors while loading input: Problem with keyword OPM Benchmark: flow_mpi_norne_4c_msw - Threads: 1 - opm-simulators 4689: change default well operability iter to true: The test run did not produce a result. E: Error: Unrecoverable errors while loading input: Problem with keyword OPM Benchmark: flow_mpi_norne_4c_msw - Threads: 8 - 2023-06-06 Master Reference: The test run did not produce a result. E: Error: Unrecoverable errors while loading input: Problem with keyword OPM Benchmark: flow_mpi_norne_4c_msw - Threads: 8 - opm-simulators 4689: change default well operability iter to true: The test run did not produce a result. E: Error: Unrecoverable errors while loading input: Problem with keyword

View result details @ https://www.ytelses.com/opm/?page=result&id=2117

ytelses avatar Jun 06 '23 18:06 ytelses

benchmark please

GitPaean avatar Jun 06 '23 22:06 GitPaean

Benchmark result overview:

Test Configuration Relative
opm-git OPM Benchmark: drogon - Threads: 1 1.015
opm-git OPM Benchmark: drogon - Threads: 8 0.991
opm-git OPM Benchmark: smeaheia - Threads: 1 1
opm-git OPM Benchmark: smeaheia - Threads: 8 1
opm-git OPM Benchmark: spe10_model_1 - Threads: 1 1.076
opm-git OPM Benchmark: spe10_model_1 - Threads: 8 1.089
opm-git OPM Benchmark: flow_mpi_extra - Threads: 1 0.985
opm-git OPM Benchmark: flow_mpi_extra - Threads: 8 1.017
opm-git OPM Benchmark: flow_mpi_norne - Threads: 1 0.988
opm-git OPM Benchmark: flow_mpi_norne - Threads: 8 0.978
  • Speed-up = Total time master / Total time pull request. Above 1.0 is an improvement. *

FAILED RUNS: OPM Benchmark: punqs3 - Threads: 1 - 2023-06-06 Master Reference: The test run did not produce a result. E: Error: Unrecoverable errors while loading input: Problem with keyword OPM Benchmark: punqs3 - Threads: 1 - opm-simulators 4689: change default well operability iter to true: The test run did not produce a result. E: Error: Unrecoverable errors while loading input: Problem with keyword OPM Benchmark: punqs3 - Threads: 8 - 2023-06-06 Master Reference: The test run did not produce a result. E: Error: Unrecoverable errors while loading input: Problem with keyword OPM Benchmark: punqs3 - Threads: 8 - opm-simulators 4689: change default well operability iter to true: The test run did not produce a result. E: Error: Unrecoverable errors while loading input: Problem with keyword OPM Benchmark: smeaheia - Threads: 1 - 2023-06-06 Master Reference: The test run did not produce a result. E: mpirun was unable to launch the specified application as it could not access OPM Benchmark: smeaheia - Threads: 8 - 2023-06-06 Master Reference: The test run did not produce a result. E: mpirun was unable to launch the specified application as it could not access OPM Benchmark: flow_mpi_norne_4c_msw - Threads: 1 - 2023-06-06 Master Reference: The test run did not produce a result. E: Error: Unrecoverable errors while loading input: Problem with keyword OPM Benchmark: flow_mpi_norne_4c_msw - Threads: 1 - opm-simulators 4689: change default well operability iter to true: The test run did not produce a result. E: Error: Unrecoverable errors while loading input: Problem with keyword OPM Benchmark: flow_mpi_norne_4c_msw - Threads: 8 - 2023-06-06 Master Reference: The test run did not produce a result. E: Error: Unrecoverable errors while loading input: Problem with keyword OPM Benchmark: flow_mpi_norne_4c_msw - Threads: 8 - opm-simulators 4689: change default well operability iter to true: The test run did not produce a result. E: Error: Unrecoverable errors while loading input: Problem with keyword

View result details @ https://www.ytelses.com/opm/?page=result&id=2118

ytelses avatar Jun 07 '23 03:06 ytelses

I did some more testing on this on other models and it significantly increase simulation time. i.e. changing the default here will require more testing and improvements on the code.

totto82 avatar Jun 07 '23 06:06 totto82

I did some more testing on this on other models and it significantly increase simulation time. i.e. changing the default here will require more testing and improvements on the code.

That was also my impression. Performance was one reason it was off by default, and also it might change results for prediction cases.

And also, it was my first time to see the following message, what was the cause of it?

OPM Benchmark: punqs3 - Threads: 1 - 2023-06-06 Master Reference: The test run did not produce a result. E: Error: Unrecoverable errors while loading input: Problem with keyword

GitPaean avatar Jun 07 '23 06:06 GitPaean

And also, it was my first time to see the following message, what was the cause of it?

The cause is given in the message. The PUNQ S3 case is broken, it does not run. It is included as one of the benchmarks. We can now finally see which benchmarks are missing, so this is an improvement to the benchmark set-up. I will check the Norne prediction case, but I expect PUNQ S3 is still broken due to unsupported functionality in the data set. I did report is when it happened, but no fix has been provided. Using the new command line switch to ignore unsupported keywords/options may be a quick fix. What do you think @atgeirr ?

alfbr avatar Jun 07 '23 06:06 alfbr

Using the new command line switch to ignore unsupported keywords/options may be a quick fix. What do you think @atgeirr ?

I will take a look, not today though,

atgeirr avatar Jun 07 '23 08:06 atgeirr