OPM
Import opm-models
It seems it's never a good time for this, but I'll open this PR for testing purposes so I can nip any problems out up front for when it is.
Tangential note: Do we know how much of doc/handbook we (i.e., the OPM project) have written? I would assume that at least some portion of it is from the Dumux project, but I have no idea how much.
There might not be a better time than now... (I am aware this needs to be discussed)
Actually, that might open the door to moving the material law managers from opm-common to opm-simulators which might make supporting adaptivity a tad easier.
I'm currently working on supporting LGRs on EclThermalLawManager, namely, getting the field properties of type int and double for a leaf grid view with LGRs, and it would be more convenient if the files were located in opm-simulators.
September is upon us. As previously agree I have updated this PR now. I hope this can be expedited quite fast so I don't have to update yet again.
- They will have to be moved. There will always be PRs and Sep 1 was agreed upon back in April as the cut-off date to do this.
- Good catch. That is definitely an oversight and I have remedied.
What happens to the open PRs in OPM-Models?
They will have to be moved. There will always be PRs and Sep 1 was agreed upon back in April as the cut-off date to do this.
Okay, then I guess you'll get to assist the authors if they run into trouble. Probably not a huge problem, because other than the compositional stuff, PR OPM/opm-models#808 and maybe PRs OPM/opm-models#813 and OPM/opm-models#512 there does not seem to be a whole lot that's worthwhile to port.
absolutely available to help, but it should simply be git format-patch and git am assuming it doesn't touch buildsystem etc.