opm-simulators icon indicating copy to clipboard operation
opm-simulators copied to clipboard

BlackoilModelEbos: introduce compile unit

Open akva2 opened this issue 2 years ago • 6 comments

And various cleanups. Another micro.

akva2 avatar Mar 03 '23 13:03 akva2

jenkins build this please

akva2 avatar Mar 03 '23 13:03 akva2

We have a branch touching on some of the same code, please wait a little bit before merging this.

atgeirr avatar Mar 06 '23 07:03 atgeirr

I think it is better to do this separate the code and the instantiation. i.e. if it really is template code then use xxx_impl.hpp and then make a xxx.cpp including impl. This make testing extensions not instantiated easier.

hnil avatar Mar 14 '23 09:03 hnil

i understand your point in general, but what's the chance of this using something other than double? (FY it's hard-coded to use double currently, I enable potentially using float as a byproduct of this PR..)

akva2 avatar Mar 20 '23 13:03 akva2

jenkins build this please

akva2 avatar Jun 30 '23 11:06 akva2

jenkins build this please

akva2 avatar Jul 31 '23 08:07 akva2