opm-grid icon indicating copy to clipboard operation
opm-grid copied to clipboard

Skip NNCs created by PINCH if one of the cells is collapsed.

Open blattms opened this issue 2 months ago • 5 comments

Collapsed here means that the points of the top and lower plane on the same pillar coincide. Later those cells will be treated as inactive in preprocess.c and will not be part of the grid. when we create the grid topology. They would present numerical problems later anyway.

Note that this means that these cells (collapsed but PORV larger than MINPVV) will now be present a barrier preventing creation of a PINCH NNC.

Fixes the assertion:

flow: ./opm/grid/cpgrid/EntityRep.hpp:121: void Dune::cpgrid::EntityRep<codim>::setValue(int, bool) [with int codim = 0]: Assertion `index_arg >= 0' failed.

Closes #505

blattms avatar Oct 14 '25 20:10 blattms

jenkins build this please

blattms avatar Oct 14 '25 20:10 blattms

With this the collapsed cell will prevent creation of an NNC. It might turn out that this is not what we want, but it is certainly way better than a model aborting in an assert. Hence I think this should be merged but we should compare behavior with others.

blattms avatar Oct 15 '25 06:10 blattms

I'd really like to see some unit tests for this in order to assess the behaviour.

bska avatar Oct 21 '25 07:10 bska

Hei, just a frienldy reminder about the schedule for the release:

Bug fixing deadline for RC2: Thursday the 23rd of October, 6pm CET.

If we are backporting this, then we need to make a RC3.

daavid00 avatar Oct 22 '25 12:10 daavid00

jenkins build this please

blattms avatar Oct 24 '25 07:10 blattms