opm-grid
opm-grid copied to clipboard
OPM
Enable DUNE grid tests
For this to work it is additionally needed that
- Entities return the "correct"[^1] number of faces (to count intersections in the tests).
- The refinement does not throw. Instead, it returns false when it cannot make a refinement.
- DUNE is at least version 2.10 due to https://gitlab.dune-project.org/core/dune-grid/-/merge_requests/734
[^1]: "Correct" here means with respect to the topology of a cube which is what the number of corners says. This is not correct for deformed entities though. Hence, this goes from wrong-wrong, to simply wrong.
The CI does not seem to have DUNE 2.10, hence, this cannot be tested there. For now, I only can assure that this works locally, but it would be nice to have an automated test so that we can see if the test from DUNE are broken.
I convert this PR to be a draft because dune 2.11 requires the grid to fulfill the grid concept check. And this will not work until
- the geometry type is returned as a value #885,
- the instantiations of
template Codim<2>::Entityare disabled (see dune-grid!778), and - the grid correctly handles the entities that cannot be handled (this original PR has some things missing for the tests to pass). See #947.