Fixed Out of Bounds NNCs

[bska]

Still observer some race condition on strange files with temperature

[bska]

I'm creating this PR in draft mode because it depends on, and contains, the earlier PR #814. I will keep the PR in a draft state until such time as it is ready for review and merging.

[blattms]

Woud it make sense to have a separate PR with just the bugfix?

[bska]

Woud it make sense to have a separate PR with just the bugfix?

For what it's worth, this is the separate PR. I'd like to get #814 into master first.

[bska]

Woud it make sense to have a separate PR with just the bugfix?

For what it's worth, this is the separate PR. I'd like to get #814 into master first.

The earlier PR was merged into the master branch. I'm marking this PR as "ready for review" and I'm running a build check.

[bska]

jenkins build this please

[hnil]

General comment: this fixes does two tings (if I remember correctly)

• remove some issues in extreem cases where volume of a collapsed cells is calculated to > 0
• remove infinite loops in the pinchActive false case

The part on mergeMinPV true is motivated by having a possibility to do pinchlike processing without needing to add artificial faces. This is need for doing mechanics. It probably will be highly favorable in other cases like thermal also.

There still a bug I do not know how to handle properly which is that the active cells between process_grdecl and minpvprocessor may be different due to the pv = 0 and c_thin may not be the same.