opm-common
opm-common copied to clipboard
OPM
Common components for OPM, in particular build system (cmake).
Replacing SFINAE, void ptr and repeated switch statements. Sits on top of https://github.com/OPM/opm-common/pull/3278 Waiting for https://github.com/OPM/opm-common/pull/3246
Sits on top of https://github.com/OPM/opm-common/pull/3281 Waiting for https://github.com/OPM/opm-common/pull/3246 this allows us to break the circular dependency between WaterPvtThermal and WaterPvtMultiplexer which forces us to use pointer semantics. dropping the pointer...
Sits on top of https://github.com/OPM/opm-common/pull/3280 Waiting for https://github.com/OPM/opm-common/pull/3246 this allows us to break the circular dependency between OilPvtThermal and OilPvtMultiplexer which forces us to use pointer semantics. dropping the pointer...
Sits on top of https://github.com/OPM/opm-common/pull/3279 Waiting for https://github.com/OPM/opm-common/pull/3246 this allows us to break the circular dependency between GasPvtThermal and GasPvtMultiplexer which forces us to use pointer semantics. dropping the pointer...
Sits on top of https://github.com/OPM/opm-common/pull/3278 Waiting for https://github.com/OPM/opm-common/pull/3246 I realize this may be controversial, and that it might have runtime implications (which we need to benchmark) but; This replaces what...
Sits on top of https://github.com/OPM/opm-common/pull/3278 Waiting for https://github.com/OPM/opm-common/pull/3246 I realize this may be controversial, and that it might have runtime implications (which we need to benchmark) but; This replaces what...
I'm re-running the GASLIFT tests and and some jobs fail due to the COORDSYS keyword not being supported, which is okay and I'll fix that. However, we get two error...
opm-common is currently the only repo where we have a src/ directory for sources (and private headers). Should we make this consistent? Either by doing this everywhere or by removing...
It seems a message intended for developers have been implemented outside the logging framework. This is very unfortunate as it confuses users. See [line 174-185 in `src/opm/input/eclipse/EclipseState/Tables/SimpleTable.cpp`](https://github.com/OPM/opm-common/blob/dd2999d0af70114dbc5055a26182a79e0ca8fe08/src/opm/input/eclipse/EclipseState/Tables/SimpleTable.cpp#L174-L184).
@bska `fip_[Inplace::Phase::SALT][globalDofIdx]` in `ecloutputblackoilmodule.hh` is only computed for reporting time steps, leading to zeros being output to summary file when time step is smaller than reporting time or chopped.
