OPM
Defer Triggering WELSPECS Report to Simulator Side
This achieves two goals
- It ensures proper sequencing with respect to other PRT file reports.
- It simplifies generating WELSPECS reports in restarted simulation runs.
To this end, amend Schedule::changed_wells() to accept an "initial step" parameter, default value zero, which can be used to control whether to list all wells as "changed" at the first step of a restarted run. Furthermore, don't emit a WELSPECS header from the PrtFile::Reports::wellSpecification() function. We defer this responsibility to the simulator side.
Finally, fix a small mistake that would always visualise the group hierarchy at the beginning of the simulation run instead of at the current report step.
I'm creating this PR in draft mode for two reasons:
- It depends on, and contains, the earlier PR #4534.
- It should be reviewed and merged together with the downstream PR OPM/opm-simulators#6107 to avoid losing the WELSPECS report, even briefly.
I will keep the PR in a draft state until such time as it is ready for review and merging.
Tested in Equinor. Results are good and looking forward to seeing this go into master.
Tested in Equinor. Results are good and looking forward to seeing this go into master.
Thank you for testing. This is greatly appreciated!
The earlier PRs have all been merged into the master branch so I'm marking this and its downstream companion PR OPM/opm-simulators#6107 as "ready for review". As noted before, the two PRs should be reviewed/merged in concert although this PR technically does not require the downstream PR to work.