opm-common icon indicating copy to clipboard operation
opm-common copied to clipboard

Use Dynamic Elapsed Time and Dates for WELSPECS Report

Open bska opened this issue 9 months ago • 2 comments

This PR replaces the hard-coded "REPORT" and "WELSPECS" strings with ones derived from the actual elapsed time and report step dates.

While here, rename the WELSPECS.cpp file to something slightly more human friendly and move the function declaration to a separate header. Furthermore, pull the MSW reports for individual wells out to separate helper functions to limit the cognitive load for readers of the main wellSpecification() function.

bska avatar Mar 20 '25 18:03 bska

I'm creating this PR in draft mode because it depends on, and contains, the earlier PR #4531. I will keep the PR in a draft state until such time as it is ready for review and merging.

bska avatar Mar 20 '25 18:03 bska

PR #4531 added dynamic time stamps for the report generation itself. This PR extends that work to also have the header reflect the simulated time. As an example, PR #4531 generated WELSPECS headers of the form

                            **************************************************************************                             
 WELSPECS AT       0.00 DAYS *                                                                        * FLOW                        
 REPORT   0     31 DEC 2007  *                                                                        * Run at 19-Mar-2025 17:41    
                             **************************************************************************                             

when running the NORNE_ATW2013 example model. Following this PR, that header now may look as follows

                             **************************************************************************
 WELSPECS AT     143.00 DAYS *                                                                        * FLOW
 REPORT    7    29-Mar-1998  *                                                                        * Run at 20-Mar-2025 19:31
                             **************************************************************************

bska avatar Mar 20 '25 19:03 bska

I'm creating this PR in draft mode because it depends on, and contains, the earlier PR #4531. I will keep the PR in a draft state until such time as it is ready for review and merging.

The earlier PR was merged into the master branch. I'm marking this as "ready for review" now and I'm running a build check.

bska avatar Apr 03 '25 08:04 bska

jenkins build this please

bska avatar Apr 03 '25 08:04 bska

PR approved and build check is green. I'll merge into master.

bska avatar Apr 03 '25 09:04 bska