opm-common icon indicating copy to clipboard operation
opm-common copied to clipboard

Varnish WELSPECS Report Implementation

Open bska opened this issue 9 months ago • 1 comments

In particular,

  • Split long lines.
  • Switch to initialising objects, especially references, using assignment syntax (=) instead of construction ({}).
  • Move function opening braces to next line.
  • Remove blanks before semicolons.
  • Apply const where reasonable.
  • Move static objects into function-local scopes where reasonable.
  • Reverse conditionals to enable "early continue".
  • Rename workers::write_WELSPECS() to workers::wellSpecification().

This is in preparation to replacing hard-coded date stamps with dynamic information.

bska avatar Mar 19 '25 15:03 bska

I'm creating this PR in draft mode because it depends on, and contains, the earlier PR #4526. I will keep the PR in a draft state until such time as it is ready for review and merging.

bska avatar Mar 19 '25 15:03 bska

The upstream PR was merged into the master branch. I'm marking this work as "ready for review".

bska avatar Apr 02 '25 10:04 bska

jenkins build this please

bska avatar Apr 02 '25 10:04 bska

jenkins build this please

bska avatar Apr 02 '25 12:04 bska

PR approved and build check is green. I'll merge into master.

bska avatar Apr 02 '25 13:04 bska