opm-common icon indicating copy to clipboard operation
opm-common copied to clipboard

Support WECON item 9

Open totto82 opened this issue 9 months ago • 1 comments

totto82 avatar Mar 06 '25 07:03 totto82

jenkins build this opm-simulators=6050 please

totto82 avatar Mar 06 '25 08:03 totto82

jenkins build this opm-simulators=6050 please

totto82 avatar Aug 26 '25 09:08 totto82

I agree with @GitPaean. You need something stronger than a linear array to maintain the inter-well relationships implied by WECON(9).

Suppose we have

WECON
  'A' ... 'F1' /
  'B' ... 'F2' /
  'C' ... 'F3' /
/

If well C shuts in we're supposed to (try to) open well F3, not any one of the wells F1, F2, or F3.

bska avatar Aug 27 '25 07:08 bska

I agree with @GitPaean. You need something stronger than a linear array to maintain the inter-well relationships implied by WECON(9).

Note that the inter-well relationship is taken care of by the simulator. This list gives all wells that the simulator opens at any point due to WECON.

totto82 avatar Aug 27 '25 08:08 totto82

jenkins build this opm-simulators=6050 please

totto82 avatar Aug 28 '25 13:08 totto82

I changed the implementation significantly and I am not yet finished so I will make it draft. Just want some help from Jenkins to sort out the missing parts.

totto82 avatar Aug 28 '25 13:08 totto82

jenkins build this opm-simulators=6050 failure_report please

totto82 avatar Aug 29 '25 07:08 totto82

jenkins build this opm-simulators=6050 failure_report please

totto82 avatar Aug 29 '25 08:08 totto82

jenkins build this opm-simulators=6050 failure_report please

totto82 avatar Aug 29 '25 13:08 totto82

jenkins build this opm-simulators=6050 failure_report please

totto82 avatar Sep 02 '25 10:09 totto82

jenkins build this opm-simulators=6050 failure_report please

totto82 avatar Sep 03 '25 06:09 totto82

jenkins build this opm-simulators=6050 failure_report please

totto82 avatar Sep 04 '25 07:09 totto82

jenkins build this opm-simulators=6050 failure_report please

totto82 avatar Sep 04 '25 13:09 totto82

jenkins build this opm-simulators=6050 please

totto82 avatar Sep 08 '25 07:09 totto82

And furthermore, to qualify as a follow on well, the well needs to be a valid SHUT well when parsing, the master branch does not deal with that yet.

I guess checking this on the parser level is less trivial than checking it on the simulator level when it is activated. Is this an abort simulation condition or just a warning?

totto82 avatar Sep 08 '25 07:09 totto82

Is this an abort simulation condition or just a warning?

I think we can treat it as a warning and disqualify the follow on well.

I guess checking this on the parser level is less trivial than checking it on the simulator level when it is activated.

It is fair to say that. If we want to do at the parsing stage, the well needs to be valid and is SHUT in the schedule when parsing WECON.

And checking at the simulator stage probably allowing more flexibility.

GitPaean avatar Sep 08 '25 08:09 GitPaean

And checking at the simulator stage probably allowing more flexibility. Done.

Thanks for the review!

totto82 avatar Sep 08 '25 08:09 totto82

jenkins build this opm-simulators=6050 failure_report please

totto82 avatar Sep 08 '25 09:09 totto82

jenkins build this opm-simulators=6050 failure_report please

totto82 avatar Sep 08 '25 10:09 totto82

jenkins build this opm-simulators=6050 please

totto82 avatar Sep 10 '25 13:09 totto82

jenkins build this opm-simulators=6050 failure_report please

totto82 avatar Sep 10 '25 14:09 totto82

jenkins build this opm-simulators=6050 failure_report please

totto82 avatar Sep 12 '25 07:09 totto82

jenkins build this opm-simulators=6050 update_data please

GitPaean avatar Sep 12 '25 09:09 GitPaean

jenkins build this opm-simulators=6050 update_data please

GitPaean avatar Sep 12 '25 09:09 GitPaean

jenkins build this opm-simulators=6050 opm-tests=1393 please

GitPaean avatar Sep 12 '25 11:09 GitPaean

@GitPaean Any reasons for not merging this?

totto82 avatar Sep 16 '25 07:09 totto82

jenkins build this opm-simulators=6050 opm-tests=1393 please

totto82 avatar Sep 16 '25 11:09 totto82

jenkins build this opm-simulators=6050 update_data please

GitPaean avatar Sep 16 '25 11:09 GitPaean

jenkins build this opm-simulators=6050 opm-tests=1399 please

GitPaean avatar Sep 16 '25 12:09 GitPaean