OPM
Output More Restart File Items
Note that despite the somewhat modest size of this PR in terms of number of changed lines, the actual impact is significant. Due to changing the number of items per well (XWEL array), connection (ICON and SCON arrays) or segment (RSEG array), as well as the contents of the INTEHEAD array, this PR breaks more or less every existing regression test. We will need to run a number of tests before we consider merging this. Thanks to @akva2's PR OPM/opm-simulators#5897, however, we have the ability to check that actual simulation results are not impacted by this change–only their on-disk representation in the restart file.
This has now been tested on several full field models in Equinor and results are excellent. @bska , thanks a lot for keeping support for restart from version 2018.2. This will be very useful.
This has now been tested on several full field models in Equinor and results are excellent
Thank you for testing, this is greatly appreciated. I need to discuss with the release manager for the upcoming 2025.04 release whether or not to bring this in right now. It touches some fundamental aspects of the user experience and that may be too risky this close to the release.
I'm going to run a full, preparatory build check for this PR now. The check will not succeed, as the structure of the restart and "init" files of our regression tests will change. I nevertheless want to confirm that those changes are only of the expected kind and that I haven't introduced any inadvertent changes to the simulation results.
jenkins build this please
I have now verified that the regression failures are of the expected kind. Simulation results (in the STARTSOL–ENDSOL block of the *.UNRST files and summary curves in the .UNSMRY files) are unchanged and the other changes are to INTEHEAD, IUAD, IUAP, and size changes in a few other arrays.
I am therefore satisfied that the current patch set is feature complete and meets the requirements. I therefore mark the PR as "ready for review".
This PR has been tested on multiple full field models in Equinor with success. Looking forward to see this go into master.
I have verified that the latest update continues to produce the expected UDA restart file output. Do I have permission to update the reference solutions and merge this now?
Do I have permission to update the reference solutions and merge this now?
yes, go for it
Thanks! I'll do that now.
PR approved, build check is green, and the updated reference solutions have been installed on the CI system. I'll merge this into the master branch now to activate the new format.