opm-common
opm-common copied to clipboard
OPM
Implement TEMP option
- always store temperature in the fluidstate
- use the enableTemperature flag for simulations where the temperature is solved sequentially
Are the THERMAL and TEMP options intended to be mutually exclusive? If so, we should not have independent flags for them (and accessors) at this level, instead we should have a single member and accessor, using something like
enum class EnergyModel
{
Implicit, // THERMAL keyword
Sequential, // TEMP keyword
None, // Neither THERMAL nor TEMP
}
Are the THERMAL and TEMP options intended to be mutually exclusive?
Yes. Your suggestion sound like a good idea. I will first prioritize to make everything compile and tests to pass
One more comment: Requiring temperature ALWAYS (in black oil) seems excessive, why do you want that?