opm-common icon indicating copy to clipboard operation
opm-common copied to clipboard

Add Restart File Support for Segment Level UDQs

Open bska opened this issue 1 year ago • 2 comments

This PR adds support for outputting and reloading the DUDS restart file array which holds values of segment level UDQs (SU*) in an (#segments)-by-(# MS wells)-by-(#segment level UDQs) dense structure. Undefined SU* values represented by the usual default UDQ restart value (-3.0e+20).

As a help to efficiency, we defer to class UDQState to export the UDQ values pertaining to all segments of a single MS well. This is easier than providing an interface based on values for a single segment at a time. On the reloading side, we introduce a new member function UDQVectors::currentSegmentUDQValue() which exposes a similar range of values for all segments of a single MS well. While here, also rework the internals of UDQVectors to resemble the structure of RstState's UDQ support.

bska avatar Sep 23 '24 20:09 bska

I'm creating this PR in draft mode because it needs quite a bit of testing and because it depends on, and contains, the earlier PR #4225. I will keep the PR in a draft state until such time as it ready for review.

bska avatar Sep 23 '24 20:09 bska

jenkins build this please

bska avatar Sep 23 '24 20:09 bska

This PR has now been tested in Equinor. This PR is fixing support for restart with segment UDQs. I'm looking forward to see this PR going into master.

tskille avatar Oct 17 '24 11:10 tskille

This PR has now been tested in Equinor. This PR is fixing support for restart with segment UDQs. I'm looking forward to see this PR going into master.

Thank you so much for testing the in-progress work. The foundational work in upstream PR #4225 must be reviewed and merged first, but then this should be ready to go.

bska avatar Oct 17 '24 11:10 bska

The upstream PR was merged into the master branch. I'm marking this PR as "ready for review" and I'm running a build check.

bska avatar Oct 17 '24 15:10 bska

jenkins build this please

bska avatar Oct 17 '24 15:10 bska

jenkins build this please

bska avatar Oct 17 '24 15:10 bska

jenkins build this please

bska avatar Oct 18 '24 07:10 bska

PR approved and build check is green. I'll merge into master.

bska avatar Oct 18 '24 08:10 bska