Additional Functionality needed for PINCH Option(4) ALL support
We will need to be able to
- Calculate vertical transmissibilities during grid setup, which needs cell and face centers and face normal. Hence there is a function to get those.
- We need an easy way to add multiple NNCs at once that will also hold transmissibilities. Those NNCs will be used to overwrite transmissibilities over pinched out cells in this case.
There are upcoming PRs in opm-grid and opm-simulators, but they still need some. I'll make this WIP because of that as changes migth be needed.
jenkins build this please
One question here is also whether to set EclipseGrid::m_multzMode to TOP unconditionally if EclipseGrid::m_pinchoutMode is ALL.
jenkins build this opm-grid=756 opm-simulators=5577 please
jenkins build this opm-grid=756 opm-simulators=5577 please
jenkins build this opm-grid=756 opm-simulators=5577 please
jenkins build this opm-grid=756 opm-simulators=5577 please
jenkins build this opm-grid=756 opm-simulators=5577 please
I notice that there's a merge conflict here, but that the PR otherwise is marked ready for review. What's the status of this overall feature–i.e., this PR and its downstream companion PRs? Is everything ready for review?
Shoot. Somehow I forgot pushing yesterday. This is now working for the test cases and the model that I have.
jenkins build this opm-grid=756 opm-simulators=5577 please
I will rebase this to make it work for users again.
Just note, that I am factoring out another PR (for OPERATER), but some tests are still giving bad results-
jenkins build this opm-grid=756 opm-simulators=5577 please
Unfortunately my answers are not seen here in threaded mode. I gues you have to go to the "Files changed" tab to see the context. Seems like there currently is nothing to here.
jenkins build this opm-grid=756 opm-simulators=5577 please
jenkins build this opm-grid=756 opm-simulators=5577 please
Why the heck should this change alugrid results?
Branches were out of sync. Retrying...
jenkins build this opm-grid=756 opm-simulators=5577 please
Seems like my push in opm-simulators was previously not successful. Let's try again
jenkins build this opm-grid=756 opm-simulators=5577 please
jenkins build this opm-grid=756 opm-simulators=5577 please
jenkins build this please
Can be merged alone but triggering jenkins for the whole chain anyway.
jenkins build this opm-grid=756 opm-simulators=5577 please
And another time. To test typo fixes in opm-grid...
jenkins build this opm-grid=756 opm-simulators=5577 please