opm-common icon indicating copy to clipboard operation
opm-common copied to clipboard

Additional Functionality needed for PINCH Option(4) ALL support

Open blattms opened this issue 1 year ago • 5 comments

We will need to be able to

  • Calculate vertical transmissibilities during grid setup, which needs cell and face centers and face normal. Hence there is a function to get those.
  • We need an easy way to add multiple NNCs at once that will also hold transmissibilities. Those NNCs will be used to overwrite transmissibilities over pinched out cells in this case.

There are upcoming PRs in opm-grid and opm-simulators, but they still need some. I'll make this WIP because of that as changes migth be needed.

blattms avatar Sep 04 '24 12:09 blattms

jenkins build this please

blattms avatar Sep 04 '24 12:09 blattms

One question here is also whether to set EclipseGrid::m_multzMode to TOP unconditionally if EclipseGrid::m_pinchoutMode is ALL.

blattms avatar Sep 04 '24 12:09 blattms

jenkins build this opm-grid=756 opm-simulators=5577 please

blattms avatar Sep 04 '24 20:09 blattms

jenkins build this opm-grid=756 opm-simulators=5577 please

blattms avatar Sep 05 '24 10:09 blattms

jenkins build this opm-grid=756 opm-simulators=5577 please

blattms avatar Sep 23 '24 13:09 blattms

jenkins build this opm-grid=756 opm-simulators=5577 please

blattms avatar Sep 24 '24 15:09 blattms

jenkins build this opm-grid=756 opm-simulators=5577 please

blattms avatar Sep 24 '24 20:09 blattms

I notice that there's a merge conflict here, but that the PR otherwise is marked ready for review. What's the status of this overall feature–i.e., this PR and its downstream companion PRs? Is everything ready for review?

bska avatar Sep 26 '24 08:09 bska

Shoot. Somehow I forgot pushing yesterday. This is now working for the test cases and the model that I have.

blattms avatar Sep 27 '24 09:09 blattms

jenkins build this opm-grid=756 opm-simulators=5577 please

blattms avatar Sep 27 '24 09:09 blattms

I will rebase this to make it work for users again.

Just note, that I am factoring out another PR (for OPERATER), but some tests are still giving bad results-

blattms avatar Sep 30 '24 09:09 blattms

jenkins build this opm-grid=756 opm-simulators=5577 please

blattms avatar Oct 01 '24 07:10 blattms

Unfortunately my answers are not seen here in threaded mode. I gues you have to go to the "Files changed" tab to see the context. Seems like there currently is nothing to here.

blattms avatar Oct 01 '24 07:10 blattms

jenkins build this opm-grid=756 opm-simulators=5577 please

blattms avatar Oct 01 '24 07:10 blattms

jenkins build this opm-grid=756 opm-simulators=5577 please

bska avatar Oct 01 '24 08:10 bska

Why the heck should this change alugrid results?

Branches were out of sync. Retrying...

blattms avatar Oct 01 '24 08:10 blattms

jenkins build this opm-grid=756 opm-simulators=5577 please

blattms avatar Oct 01 '24 08:10 blattms

Seems like my push in opm-simulators was previously not successful. Let's try again

blattms avatar Oct 01 '24 09:10 blattms

jenkins build this opm-grid=756 opm-simulators=5577 please

blattms avatar Oct 01 '24 09:10 blattms

jenkins build this opm-grid=756 opm-simulators=5577 please

blattms avatar Oct 01 '24 18:10 blattms

jenkins build this please

atgeirr avatar Oct 02 '24 07:10 atgeirr

Can be merged alone but triggering jenkins for the whole chain anyway.

blattms avatar Oct 03 '24 10:10 blattms

jenkins build this opm-grid=756 opm-simulators=5577 please

blattms avatar Oct 03 '24 10:10 blattms

And another time. To test typo fixes in opm-grid...

blattms avatar Oct 04 '24 13:10 blattms

jenkins build this opm-grid=756 opm-simulators=5577 please

blattms avatar Oct 04 '24 13:10 blattms