opm-common icon indicating copy to clipboard operation
opm-common copied to clipboard

Bugfix: test saturation values for table order.

Open atgeirr opened this issue 1 year ago • 8 comments

As discussed in https://github.com/OPM/opm-common/pull/4081, fixing a bug potentially turning the saturation tables.

atgeirr avatar Jul 19 '24 13:07 atgeirr

jenkins build this please

atgeirr avatar Jul 19 '24 13:07 atgeirr

The high number of test failures is a bit disheartening, but on the other hand the interpolation seems to be robust with respect to the order of the saturation values, so it should not matter significantly (i.e. getting wrong results) if order is flipped or not.

atgeirr avatar Jul 24 '24 14:07 atgeirr

What does the Sw stand for?

blattms avatar Jul 25 '24 06:07 blattms

What does the Sw stand for?

I think in this particular context it should probably be just s, for saturation. While not 100% sure of the lineage of the code it probably stood for "saturation, wetting" in the original context. Which of course is very easy to confuse with water saturation.

atgeirr avatar Jul 25 '24 07:07 atgeirr

So values is the input to the tabulated functions and Swvalues are used for interpolate the the result for a particular value.

blattms avatar Jul 25 '24 11:07 blattms

So values is the input to the tabulated functions and Swvalues are used for interpolate the the result for a particular value.

This class gives a function f(x) by piecewise linear interpolation, where the (x_i, f(x_i)) data are (swValues[i], values[i]). Which is maybe what you said, but I was not sure...

atgeirr avatar Jul 25 '24 11:07 atgeirr

jenkins build this please

atgeirr avatar Jan 03 '25 10:01 atgeirr

jenkins build this failure_report please

atgeirr avatar Jan 03 '25 12:01 atgeirr