opm-common icon indicating copy to clipboard operation
opm-common copied to clipboard

Support instantaneous flow rates in extended network (WEFAC and GEFAC item 3)

Open vkip opened this issue 1 year ago • 3 comments

No restart support here - will come in a separate PR.

vkip avatar Jun 05 '24 07:06 vkip

jenkins build this opm-simulators=5410 please

vkip avatar Jun 05 '24 07:06 vkip

jenkins build this opm-simulators=5410 please

vkip avatar Jun 05 '24 08:06 vkip

jenkins build this opm-simulators=5410 please

GitPaean avatar Jun 13 '24 07:06 GitPaean

jenkins build this opm-simulators=5410 please

vkip avatar Jan 17 '25 15:01 vkip

jenkins build this opm-simulators=5410 please

vkip avatar Jan 20 '25 12:01 vkip

jenkins build this opm-simulators=5410 please

GitPaean avatar Feb 11 '25 21:02 GitPaean

It looks generally good to me. I only have some minor comments for you to address.

Thank you for the review. I have now tried to update accordingly.

vkip avatar Feb 14 '25 09:02 vkip

jenkins build this opm-simulators=5410 please

vkip avatar Feb 14 '25 10:02 vkip

Thanks for the update. It looks good to me and I am getting it in now.

GitPaean avatar Feb 14 '25 13:02 GitPaean