opm-common icon indicating copy to clipboard operation
opm-common copied to clipboard

Add necessary templating to support float in simulators

Open akva2 opened this issue 10 months ago • 9 comments

These are required changes to enable float support in opm-simulators. I only open the PR to give visibility to those who want to test with float. You are free to comment if you find something of course but I do not ask for this to be merged in this form.

akva2 avatar Apr 16 '24 12:04 akva2

jenkins build this opm-models=869 opm-simulators=5286 rocm hipify serial please

akva2 avatar Jun 03 '24 11:06 akva2

jenkins build this opm-models=896 opm-simulators=5286 rocm hipify serial please

akva2 avatar Jun 03 '24 12:06 akva2

jenkins build this opm-models=896 opm-simulators=5286 rocm hipify serial please

akva2 avatar Jun 03 '24 12:06 akva2

jenkins build this opm-models=896 opm-simulators=5286 rocm hipify serial please

akva2 avatar Jun 03 '24 14:06 akva2

Is this PR a prerequisite for the downstream PRs OPM/opm-models#896 and OPM/opm-simulators#5286? If not, is there some other kind of ordering requirement between these PRs or can they be reviewed/merged in any order?

bska avatar Jun 03 '24 15:06 bska

simulators need them both, but there is no interdependency between the others.

akva2 avatar Jun 03 '24 15:06 akva2

jenkins build this opm-models=896 opm-simulators=5286 rocm hipify serial please

akva2 avatar Jun 03 '24 16:06 akva2

jenkins build this opm-models=896 opm-simulators=5286 rocm hipify serial please

akva2 avatar Jun 03 '24 17:06 akva2

jenkins build this opm-models=896 opm-simulators=5286 rocm hipify serial please

akva2 avatar Jun 04 '24 12:06 akva2

jenkins build this please

akva2 avatar Aug 26 '24 06:08 akva2

jenkins build this please

akva2 avatar Aug 26 '24 06:08 akva2

jenkins build this please

akva2 avatar Aug 26 '24 07:08 akva2