opm-common icon indicating copy to clipboard operation
opm-common copied to clipboard

Published 20 hours ago • verified publisher icon OPM

Blackoilthermal fixes final

Open hnil opened this issue 10 months ago • 2 comments

-- added mixing model for thermal blackoil -- TEMP is now set energy=enthalpy -- THERMAL use enthalpy and energy different

This is draft pullrequest befor all commits are removed.

hnil avatar Apr 16 '24 09:04 hnil

.. Now testing on THERMAL and TEMP cases is needed to get this in, @vkip and @totto82 do you have a clear idea of the cases you think should be tested, and when you can do this testing?

I have some TEMP cases that I can start looking at once the merge conflicts are resolved.

vkip avatar Apr 19 '24 06:04 vkip

jenkins build this please

atgeirr avatar Apr 24 '24 09:04 atgeirr

jenkins build this please

atgeirr avatar Sep 09 '24 12:09 atgeirr

jenkins build this update_data failure_report please

atgeirr avatar Sep 11 '24 12:09 atgeirr

minor niggle on jenkins (forgot to adjust a path for not being triggered from simulators). i'll rerun.

akva2 avatar Sep 11 '24 12:09 akva2

jenkins build this update_data failure_report please

akva2 avatar Sep 11 '24 12:09 akva2

jenkins build this failure_report please

akva2 avatar Sep 11 '24 13:09 akva2

jenkins build this opm-tests=4014 please

atgeirr avatar Sep 11 '24 15:09 atgeirr

jenkins build this opm-tests=1226 please

akva2 avatar Sep 11 '24 16:09 akva2

Thanks for fixing my Jenkins messup, merging!

atgeirr avatar Sep 11 '24 17:09 atgeirr

Thanks for fixing my Jenkins messup, merging!

Did you accidentally not merge the associate update to the reference solutions, OPM/opm-tests#1226?

bska avatar Sep 11 '24 18:09 bska

Did you accidentally not merge the associate update to the reference solutions, OPM/opm-tests#1226?

That is correct, my brain is not working today. Merged it now!

atgeirr avatar Sep 11 '24 21:09 atgeirr

Merged [reference solution update] now!

Thanks!

bska avatar Sep 12 '24 06:09 bska