OPM
SALTSOL: change units of item 1 to Salinity
I believe item 1 (SALTSOL) should have units of Salinity (LB/STB) rather than density (LB/FT3) to be consistent with e.g. SALTVD. This only affects FIELD units.
I believe item 1 (SALTSOL) should have units of Salinity (LB/STB) rather than density (LB/FT3) to be consistent with e.g. SALTVD.
Possibly. I seem to recall that there was quite a bit of discussion concerning the unit handling here when the feature was first introduced (PR #2981). @goncalvesmachadoc : Do you remember the reasoning for these units of measurement?
@bska I agree with @gdfldm , this is a bug not caught because tests are in METRIC. The manual is correct (LB/STB).
I agree with @gdfldm , this is a bug not caught because tests are in METRIC. The manual is correct (LB/STB).
Thanks @goncalvesmachadoc–really appreciate it. In that case this looks good to me. I'll run a build check just to be sure we don't break anything and then I'll merge once the build is okay.