opm-common icon indicating copy to clipboard operation
opm-common copied to clipboard

[testing] adding member to check whether WVFPDP active

Open GitPaean opened this issue 2 years ago • 3 comments

alternatively, we can use

    bool WVFPDP::active() const {
        return this->dp != 0.0 || this->m_fp != 1.0;
    }

GitPaean avatar Nov 01 '23 12:11 GitPaean

jenkins build this opm-simulators=4958 please

GitPaean avatar Nov 01 '23 12:11 GitPaean

alternatively, we can use

    bool WVFPDP::active() const {
        return this->dp != 0.0 || this->m_fp != 1.0;
    }

Using this way will be much less work and not need to think about how it should be affected by the RESTART implementation.

We can also explore usage of std::optional for this purpose.

GitPaean avatar Nov 01 '23 14:11 GitPaean

jenkins build this opm-simulators=4958 please

GitPaean avatar Nov 24 '23 08:11 GitPaean