opm-common icon indicating copy to clipboard operation
opm-common copied to clipboard

remove checking finalized with NDEBUG

Open hnil opened this issue 2 years ago • 2 comments

A bit better performances with NDEBUG and a move to faster property evaluation.

hnil avatar Sep 07 '23 12:09 hnil

jenkins build this please

bska avatar Sep 07 '23 12:09 bska

If https://github.com/OPM/opm-common/pull/3427 is merged this will not be needed. Although we could make the change that it is turned off by default also for debug builds, but that is not quite what the current version does. If that is what you want, just a few lines needs to change compared to the master:

#define OPM_CHECK_PARAM_FINALIZED 1

Replace that with:

#ifndef OPM_CHECK_PARAM_FINALIZED
#define OPM_CHECK_PARAM_FINALIZED 0
#endif

I would support merging that. Then you would need to add -DOPM_CHECK_PARAM_FINALIZED=1 to your build routine to get the explicit finalization check. Still available, just not on by default.

atgeirr avatar Sep 28 '23 09:09 atgeirr