opm-common icon indicating copy to clipboard operation
opm-common copied to clipboard

changed to using input type unit convertions for field props

Open hnil opened this issue 2 years ago • 4 comments

-- make input and output consistent without more than input definition -- simplifies output of field props with combined units (i.e. length^i time^j temperature^k

hnil avatar Aug 08 '23 11:08 hnil

need checking in opm-simulators before merging.

hnil avatar Aug 08 '23 11:08 hnil

One more comment. We already have a UnitSystem object in InitIO::write() and that one is supposed to be the same as—or at least equivalent to—the one stored in the FieldProps object. If we look narrowly at the task of writing the output file, we might not need the new member functions in FieldProps or FieldPropsManager, but I am not opposed to adding them either.

bska avatar Aug 09 '23 14:08 bska

Maybe we should have one UnitSystem at least of each type. And deside for that. The one I points to is the one used for in put I believe.

hnil avatar Aug 11 '23 11:08 hnil

The one I points to is the one used for in put I believe.

That is true, but so is the one in InitIO::write().

bska avatar Aug 11 '23 11:08 bska