opm-common
opm-common copied to clipboard
OPM
Log and update fixes
Fix some logging annoyances, and correct what I think is a minor bug in the Well::updateConnections() method.
@joakim-hove I am not 100% sure of the bugfix in the first commit, good if you can verify.
@joakim-hove and I discussed this, and concluded that we should assume in this code that the grid properties in question (pvtnum) should be considered fixed (not allowed to change during the schedule). If it is changed anyway, one must reconstruct the well object.
There was a bug discovered though, that affect both the old and new code! If defaulted, the pvtnum will be 0 initially, then overwritten the first time connections are added. If more are added later, we will not know that it was defaulted anymore, and therefore not potentially change pvtnum to the correct one, if there is a new top connection. Fix not hard, but would require adding a bool and therefore also serialization etc.
Can this be closed?
I don't think so because the underlying issue is still present, but I'll defer to @atgeirr for the definitive answer.
