ResInsight icon indicating copy to clipboard operation
ResInsight copied to clipboard

Published 20 hours ago • verified publisher icon OPM

Avoid mixing Python versions during github action run

Open magnesj opened this issue 3 years ago • 1 comments
trafficstars

From the log, we can see that the github action variable pythonLocation is changing from 3.8 to 3.10 after running action https://github.com/jurplel/install-qt-action/tree/v2

https://github.com/OPM/ResInsight/actions/runs/3080820654/jobs/4978625692

Related issue related to protobuf https://github.com/protocolbuffers/protobuf/issues/10075

magnesj avatar Sep 19 '22 12:09 magnesj

Issues have been seen in protobuf>3.20 with the current version of grpc used in ResInsight.

magnesj avatar Sep 20 '22 06:09 magnesj

Can this be retested, and checked whether that will allow unpinning of protobuf in requirements.txt?

berland avatar Nov 30 '22 14:11 berland

Bumping the question from Håvard here , possible to have a look at the pinning @magnesj ?

oysteoh avatar Jun 23 '23 12:06 oysteoh

I can look into this next week. What is your preferred solution, no pinning at all?

magnesj avatar Jun 23 '23 13:06 magnesj

If possible the best thing is to remove pinning :+1:

oysteoh avatar Jun 23 '23 13:06 oysteoh

The pinning of modules was introduced in https://github.com/OPM/ResInsight/commit/587f700ae4db4dfcca273449423e55aa273d44e6. At this point, the latest version of grpc and protobuf caused issues.

The protobuf issue was fixed in 4.21.9, see https://github.com/protocolbuffers/protobuf/issues/10075#issuecomment-1309567465

These issues are now resolved and the pinning can be removed.

magnesj avatar Jun 26 '23 08:06 magnesj

@oysteoh, pinning is now removed. Please let us know if this solves your issues.

magnesj avatar Jun 26 '23 12:06 magnesj

Are you planning on making a new tag on this release on pypi? We are getting the rips package from there and cannot test the change until that is done 👍

oysteoh avatar Jun 26 '23 14:06 oysteoh

c++ files related to grpc are generated using the protoc tool. This tool is installed using vcpkg and, the current version of this tool is 3.15.8. The protoc tool is launched from cmake in https://github.com/OPM/ResInsight/blob/dev/GrpcInterface/CMakeLists.txt

Python code is generated based on the same proto files, and they are generated using the Python package grpcio-tools in CMakeLists.txt

The current version of grpcio-tools is 1.33. This version causes issues on readthedocs https://readthedocs.org/projects/python-rips-doc/builds/21129013/

Investigate if it is possible to use the latest version of grpcio-tools with the current grpc used in c++.

Latest release of vcpkg contains protoc version 3.21.12 https://github.com/microsoft/vcpkg/commits/master/ports/protobuf

magnesj avatar Jun 27 '23 07:06 magnesj

Updated python packages are verified working as expected on Equinor infrastructure.

magnesj avatar Jul 05 '23 10:07 magnesj