ePO icon indicating copy to clipboard operation
ePO copied to clipboard

How is the relationship between `epo:ReviewDecision` and `epo:ReviewRequest` represented in eForms?

Open csnyulas opened this issue 9 months ago • 2 comments

The property epo:resolvesReviewRequest in ePO 4.0.0 (which will be replaced with the property epo:resolvesReviewRequest in ePO 5.0.0, according to #756) is supposed to link a epo:ReviewDecision to a epo:ReviewRequest, as shown below

epo 4.0.0: Image

epo 5.0.0: Image

Although this property is mandatory (cardinality is [1]), the eForms SDK does not seem to provide a field to express this relation. Is this really the case or we are missing something? This will lead to SHACL violation on any notice that contains information describing a epo:ReviewDecision instance.

csnyulas avatar Apr 10 '25 14:04 csnyulas

Please be aware that there an related issue opened on the eForms SDK project, https://github.com/OP-TED/eForms-SDK/issues/1188, and especially consider the note that explains why the field BT-785-Review is most likely not appropriate (or cannot be used) to generate this connection.

csnyulas avatar Apr 10 '25 22:04 csnyulas

@pdonohoe suggests in his comment https://github.com/OP-TED/eForms-SDK/issues/1188#issuecomment-2806196558, that the BT-785-Review field should be used (also) for linking the epo:ReviewDecision and epo:ReviewRequest instances.

It is not clear to me in what situation should we do that, so I requested some clarifications: https://github.com/OP-TED/eForms-SDK/issues/1188#issuecomment-2809073143

csnyulas avatar Apr 16 '25 11:04 csnyulas

During the WGM of 13/05/2025, it was agreed that, as of ePO 5.1.0, a ReviewDecision may answer to none or many ReviewRequests, as depicted below:

Image

andreea-pasare avatar May 13 '25 13:05 andreea-pasare