core icon indicating copy to clipboard operation
core copied to clipboard

Using symbol __unix__ to improve portability

Open vtamara opened this issue 6 years ago • 3 comments

Replaces https://github.com/ONLYOFFICE/core/pull/66

vtamara avatar Aug 28 '18 04:08 vtamara

Sorry for late response. According to https://stackoverflow.com/questions/7063303/macro-unix-not-defined-in-macos-x __unix__ is not available on MacOSX and iOS, so we think it may cause trouble in some cases for your changes (in some of changed lines - there is already check for macos, but I think not at all cases)

ShockwaveNN avatar Jul 03 '19 15:07 ShockwaveNN

This project is great. I wonder if I can compile it on vs2017?

lugeluge avatar Aug 08 '19 03:08 lugeluge

CLA assistant check
Thank you for your submission! We really appreciate it. Like many open source projects, we ask that you sign our Contributor License Agreement before we can accept your contribution.
You have signed the CLA already but the status is still pending? Let us recheck it.

CLAassistant avatar Mar 22 '21 08:03 CLAassistant