Add the onlyoffice Debian repo at installation time while installing deb file manually
This issue is unique.
- [X] I have used the search tool and did not find an issue describing my idea.
Your idea.
Currently there are two ways to install the Desktop Editors on Debian and derivated distros using the Debian package manager:
- use the .deb installer (this is the simplest method, and I would say even the most promoted one on the website and GitHub),
- add the onlyoffice.com Debian repo to source.list.d and the public key to trusted.gpg.d as recommended (and only mentioned) in https://helpcenter.onlyoffice.com/installation/desktop-install-ubuntu.aspx.
Instead of providing a .deb installer and separately the instructions to add the Debian onlyoffice.com repo, I think it would be convenient to include the latter in the postinst script of the .deb installer directly.
Different vendors use this approach, like Microsoft, as shown in https://github.com/microsoft/vscode/blob/62046733313fac807a8221f2c2ba6126b833e2a1/resources/linux/debian/postinst.template#L31-L77. The result would be an installer that is easy to use, can auto-update the product, and fits with the Debian package manager.
Hi, not sure if that's actually a good practice to write your repo in system while installing deb package
For example for Centos we got separate rpm package to only install repo and I think (at least for centos) it'a proper way to adding repos via package
But installing repo inside software package - not so sure
I understand why you want that but I'm interested to hear from someone who understand with knowledge of Debian/Ubuntu 3rd party packages guidelines
Unfortunately, I cannot make a comparison with rpm packages because I don't have lots of experience with them.
I understand your concerns. However, I want to point out that this approach doesn't do anything unconventional. First, it interfaces correctly with the apt configs and queries/extracts the locations of the "sourceparts" and "trustedparts" directories. (This step is necessary because the default locations may have been modified by the user). After that, it adds the repo URL and the public key in the "sourceparts" and "trustedparts" directories, exactly how these folders are intended to be used.
In addition, it seems like this approach has been used for almost a decade:
- https://askubuntu.com/questions/190140/do-deb-installed-apps-get-updates
- https://askubuntu.com/questions/431905/how-does-update-work-with-programs-installed-from-deb-file
And multiple companies are still using it (for example, Google with Chrome, Dropbox with its client, Microsoft with all the software it offers as a .deb, and if I remember correctly, in the past, Spotify with its client).
Of course, other organizations using this approach doesn't mean this is the best or the most appropriate one, but I think it's worth mentioning.
@andscal Fair enough, thanks for detailed description
I've created issue 58383 in our private issue tracker to discuss this with our team, but I cannot make any promises on estimates or resolution
But thanks for idea anyway
Moving this issue to DocumentServer repo, since it's our base product and problem actual there too