DocumentServer icon indicating copy to clipboard operation
DocumentServer copied to clipboard

Published 20 hours ago • verified publisher icon ONLYOFFICE

Loss of CustomXML parts/tags in XLSX & PPTX files

Open ameys2907 opened this issue 3 years ago • 16 comments

Do you want to request a feature or report a bug? Bug

What is the current behavior? When a PPTX or XLSX file having custom meta data is edited and saved back from DocumentServer, the customXml parts are lost in the said files. It works for DOCX files, my guess is because of ticket 792. Files: Book.xlsx Presentation.pptx Document.docx

If the current behavior is a bug, please provide the steps to reproduce and if possible a minimal demo of the problem.

  1. Unzip PPTX or XLSX file having custom metadata (above given files) and observe the folder structure.
  2. Open the file in DocumentServer, edit and save it back.
  3. Unzip the file and compare the folder structure with the previous one, the customXml folder is lost.

Before : image

After edit and saveback : image

What is the expected behavior? The custom meta data of the file should persist after editing and saveback in XLSX and PPTX formats also.

Did this work in previous versions of DocumentServer? No

DocumentServer version: 6.3.1

Operating System: Any

Browser version: Any

ameys2907 avatar Dec 22 '21 09:12 ameys2907

DocumentServer version: 6.3.1

Hi, I think we fixed a lot of this issues at v6.4

See https://github.com/ONLYOFFICE/DocumentServer/issues/1318

So please update to latest stable v6.4.2 and see if this problem persists

ShockwaveNN avatar Dec 22 '21 09:12 ShockwaveNN

Okay will check and let you know asap.

DocumentServer version: 6.3.1

Hi, I think we fixed a lot of this issues at v6.4

See #1318

So please update to latest stable v6.4.2 and see if this problem persists

ameys2907 avatar Dec 22 '21 15:12 ameys2907

DocumentServer version: 6.3.1

Hi, I think we fixed a lot of this issues at v6.4

See #1318

So please update to latest stable v6.4.2 and see if this problem persists

I checked, It is only fixed for DOCX files, not PPTX and XLSX files.

ameys2907 avatar Dec 23 '21 04:12 ameys2907

Thanks for your issue, I've took a look any my findings are

  1. For xlsx files seems that we already fixed loss of customXml. I've checked dev version v7.0.0 and seems it's not losing xlsx customXML. We hope we'll be ready to release it early next year
  2. For pptx - your problem is reproduces on either stable version and v7.0.0. We indeed losing customXML in pptx. I've created issue 54673 in our private issue tracker

ShockwaveNN avatar Dec 23 '21 07:12 ShockwaveNN

Thanks for your issue, I've took a look any my findings are

  1. For xlsx files seems that we already fixed loss of customXml. I've checked dev version v7.0.0 and seems it's not losing xlsx customXML. We hope we'll be ready to release it early next year
  2. For pptx - your problem is reproduces on either stable version and v7.0.0. We indeed losing customXML in pptx. I've created issue 54673 in our private issue tracker

Can I get the link of XLSX fix ?

ameys2907 avatar Dec 23 '21 10:12 ameys2907

You can try using docker image onlyoffice/4testing-documentserver-ee:7.0.0.96

But please not that it's not stable version and can be contain any number of issues, but your xlsx downloaded fine

ShockwaveNN avatar Dec 23 '21 10:12 ShockwaveNN

You can try using docker image onlyoffice/4testing-documentserver-ee:7.0.0.96

But please not that it's not stable version and can be contain any number of issues, but your xlsx downloaded fine

Actually I was asking if I can get a link of the fixed changes so that we can port it into my own version for the time being. Something like this ONLYOFFICE/core@1a722a4 ONLYOFFICE/sdkjs@ecbe369

ameys2907 avatar Dec 24 '21 05:12 ameys2907

Sorry, I don't think I remember when our dev team fixed it, so it took a lot of time to figure out And I think you cannot just cherry-pick those commits in your version, because it may break other parts. I think it's better to wait for v7.0.0 release

ShockwaveNN avatar Dec 24 '21 06:12 ShockwaveNN

This issue is fixed for pptx files via https://github.com/ONLYOFFICE/sdkjs/commit/55ec1abc35545ba91ac3ddfb41b020195f341aa6 https://github.com/ONLYOFFICE/core/commit/995b87e3bc495b09255eb6c26a672da3c7633033

And will be released as v7.2 in future (Sorry, no ETA)

ShockwaveNN avatar Aug 04 '22 12:08 ShockwaveNN

This issue is fixed for pptx files via ONLYOFFICE/sdkjs@55ec1ab ONLYOFFICE/core@995b87e

And will be released as v7.2 in future (Sorry, no ETA)

Thanks for the update.

ameys2907 avatar Aug 08 '22 06:08 ameys2907

This seems to be broken for docx files again on 7.1.1 @ShockwaveNN can you confirm that it is fixed in 7.2 for docx as well?

teamoo avatar Sep 02 '22 08:09 teamoo

@teamoo Yeah, thanks for noticifing, yes on v7.1.1 something is not right and item1.xml... files are present but empty

But on v7.2 they are ok image

ShockwaveNN avatar Sep 02 '22 08:09 ShockwaveNN

@teamoo Yeah, thanks for noticifing, yes on v7.1.1 something is not right and item1.xml... files are present but empty

But on v7.2 they are ok image

@ShockwaveNN, Thanks for the confirmation. has the release date been fixed for v7.2?

ameys2907 avatar Sep 05 '22 05:09 ameys2907

@amaigaki We usually have no exact date for releases, but we planning to do it in September if everything went as planned

ShockwaveNN avatar Sep 05 '22 06:09 ShockwaveNN

For important bugs/regressions it would be nice to have them fixed in minor release i.e. 7.1.2

cpot avatar Sep 05 '22 12:09 cpot

@cpot We are on final stage of preparing v7.2.0 so releasing v7.1.2 will postpone v7.2.0

But as I always say to you - you can always contact [email protected] and they have more power to make some thing to happen

ShockwaveNN avatar Sep 05 '22 12:09 ShockwaveNN

DocumentServer v7.2 is released. This issue should be fixed

Feel free to comment or reopen it if you got further questions

ShockwaveNN avatar Sep 23 '22 16:09 ShockwaveNN