CommunityServer icon indicating copy to clipboard operation
CommunityServer copied to clipboard

Generic oAuth2 login provider

Open VincentSC opened this issue 3 years ago • 5 comments

From what I see in module/ASC.Thrdparty/ASC.FederatedLogin/LoginProviders, it should not be hard to make a generic oAuth2 login provider. Before I build this and create a PR, can I ask why this has not happened yet?

VincentSC avatar Feb 28 '22 15:02 VincentSC

Question: why is the callback https://service.onlyoffice.com/oauth2.aspx and not https://your.domain/oauth2.aspx?

VincentSC avatar Mar 01 '22 08:03 VincentSC

Hello @VincentSC Unfortunately, we haven't been able to implement it yet. Please open a pull request and our developers will review it.

Carazyda avatar Mar 01 '22 12:03 Carazyda

Making a sloppy generic oAuth2 provider will not be a problem, but prefer to make one that is usable. Do you have some design documentation I could use? I have some doubts, and since Ascensio System Limited aka OnlyOffice wrote the code, I could use the original design docs. cc @ivanovnikolay

VincentSC avatar Mar 15 '22 14:03 VincentSC

Hi @VincentSC, I'm afraid that, after some discussion, we've decided to not include this in the current development plans (at least, at the moment). However, we'll be sure to make note of it as a requested addition.

SergeyKorneyev avatar Mar 16 '22 12:03 SergeyKorneyev

@SergeyKorneyev Not sure if you understood my request. I can make it and send in a PR. I just need some more context, as I cannot get the full overview. I can also focus on the version that works for my own situation only, the sloppy version.

VincentSC avatar Mar 16 '22 12:03 VincentSC