precious-plastic-kit icon indicating copy to clipboard operation
precious-plastic-kit copied to clipboard

Published 20 hours ago • verified publisher icon ONEARMY

Spacer in Hardox

Open urpylka opened this issue 3 years ago • 4 comments

Please check location of the SHRPRO-V1 1120.14-A Spacer 4mm. Now it is in folder Hardox_4mm. But it should be placed in Steel 4mm folder (check the blueprint).

urpylka avatar Apr 19 '21 14:04 urpylka

Can any of the maintainers advise on this?

Not sure which one is correct.

@urpylka could you provide more context to what the issue is to help the maintainers resolve the issue?

Is it just that the spacer file should be moved from one folder to the other?

If so this may be a good first issue to make a pull request, that way all the maintainers need to do is to click one button to make the correction.

darigovresearch avatar May 30 '21 18:05 darigovresearch

Yes, I suggest to move file to another folder. I opened this issue to get feedback about that from maintainers. I've got answer in Discord (see image).

I can make PR if it will be accepted.

photo_2021-05-31 21 52 26

urpylka avatar May 31 '21 17:05 urpylka

Thanks for the clarification, you're welcome to put in a pull request but as we don't have privileges on the repository can't guarantee that it will be merged.

However there is only one way to find out if it will be merged and that is making a pull request

darigovresearch avatar May 31 '21 18:05 darigovresearch

Merging pull request #30 should resolve this issue, thanks for making the pull request

darigovresearch avatar Jun 05 '21 21:06 darigovresearch