community-platform icon indicating copy to clipboard operation
community-platform copied to clipboard

added globe and location buttons to map

Open motuz0001 opened this issue 1 year ago • 1 comments

PR Checklist

PR Type

What kind of change does this PR introduce?

  • [ ] Bugfix (fixes an issue)
  • [x] Feature (adds functionality)
  • [ ] Code style update
  • [ ] Refactoring (no functional changes)
  • [ ] Build related changes
  • [ ] CI related changes
  • [ ] Documentation changes
  • [ ] Other... Please describe:

What is the current behavior?

The map currently does not have a buttons for unzooming to global view and zooming to user's location.

What is the new behavior?

  • Added a globe button that allows users to unzoom to a world view of the map.
  • Added a location button that zooms into the user's current geographic location.

image

Does this PR introduce a breaking change?

  • [ ] Yes
  • [x] No

Git Issues

Closes #3879

What happens next?

Thanks for the contribution! We try to make sure all PRs are reviewed ahead of our monthly maintainers call (first Monday of the month)

If the PR is working as intended it'll be merged and included in the next platform release, if not changes will be requested and re-reviewed once updated.

If you need more immediate feedback you can try reaching out on Discord in the Community Platform development channel.

motuz0001 avatar Oct 22 '24 21:10 motuz0001

onearmy-community-platform    Run #6529

Run Properties:  status check passed Passed #6529  •  git commit d4cd699f24: changed values in tests
Project onearmy-community-platform
Branch Review pull/3913
Run status status check passed Passed #6529
Run duration 05m 07s
Commit git commit d4cd699f24: changed values in tests
Committer Matúš Motyka
View all properties for this run ↗︎

Test results
Tests that failed  Failures 0
Tests that were flaky  Flaky 1
Tests that did not run due to a developer annotating a test with .skip  Pending 0
Tests that did not run due to a failure in a mocha hook  Skipped 0
Tests that passed  Passing 74
View all changes introduced in this branch ↗︎

cypress[bot] avatar Oct 22 '24 22:10 cypress[bot]

hey @joperafe , I'm not sure if you'll be the one reviewing this or if someone else will, but I think it's finally done. I fought with the tests for a while but eventually found a way to check the zoom. Let me know if any changes are needed or if something is wrong. Thanks!

motuz0001 avatar Nov 05 '24 13:11 motuz0001

or maybe @benfurber should review this, not sure hah

motuz0001 avatar Nov 05 '24 13:11 motuz0001

hey @joperafe , I'm not sure if you'll be the one reviewing this or if someone else will, but I think it's finally done. I fought with the tests for a while but eventually found a way to check the zoom. Let me know if any changes are needed or if something is wrong. Thanks!

Hi there! No no, not me. First timer Just went through the PR back then and decided to say something :D

Thank you

joperafe avatar Nov 05 '24 15:11 joperafe

Oh and a complex rebase is needed!

benfurber avatar Nov 05 '24 16:11 benfurber

hey @benfurber , I hope all is fixed now and rebase is okay

motuz0001 avatar Nov 07 '24 00:11 motuz0001

Awesome, thank you @motuz0001!

benfurber avatar Nov 07 '24 13:11 benfurber

@all-contributors add @motuz0001 for code

benfurber avatar Nov 07 '24 13:11 benfurber

@benfurber

I've put up a pull request to add @motuz0001! :tada:

allcontributors[bot] avatar Nov 07 '24 13:11 allcontributors[bot]