added globe and location buttons to map
PR Checklist
- [x] - Commit messages are descriptive, it will be used in our Release Notes
- [x] - Unit and e2e tests for the changes that have been added (for bug fixes / features)
PR Type
What kind of change does this PR introduce?
- [ ] Bugfix (fixes an issue)
- [x] Feature (adds functionality)
- [ ] Code style update
- [ ] Refactoring (no functional changes)
- [ ] Build related changes
- [ ] CI related changes
- [ ] Documentation changes
- [ ] Other... Please describe:
What is the current behavior?
The map currently does not have a buttons for unzooming to global view and zooming to user's location.
What is the new behavior?
- Added a globe button that allows users to unzoom to a world view of the map.
- Added a location button that zooms into the user's current geographic location.
Does this PR introduce a breaking change?
- [ ] Yes
- [x] No
Git Issues
Closes #3879
What happens next?
Thanks for the contribution! We try to make sure all PRs are reviewed ahead of our monthly maintainers call (first Monday of the month)
If the PR is working as intended it'll be merged and included in the next platform release, if not changes will be requested and re-reviewed once updated.
If you need more immediate feedback you can try reaching out on Discord in the Community Platform development channel.
onearmy-community-platform
Run #6529
Run Properties:
Passed #6529 •
d4cd699f24: changed values in tests
| Project |
onearmy-community-platform
|
| Branch Review |
pull/3913
|
| Run status |
|
| Run duration | 05m 07s |
| Commit |
|
| Committer | Matúš Motyka |
| View all properties for this run ↗︎ | |
| Test results | |
|---|---|
|
|
0
|
|
|
1
|
|
|
0
|
|
|
0
|
|
|
74
|
| View all changes introduced in this branch ↗︎ | |
hey @joperafe , I'm not sure if you'll be the one reviewing this or if someone else will, but I think it's finally done. I fought with the tests for a while but eventually found a way to check the zoom. Let me know if any changes are needed or if something is wrong. Thanks!
or maybe @benfurber should review this, not sure hah
hey @joperafe , I'm not sure if you'll be the one reviewing this or if someone else will, but I think it's finally done. I fought with the tests for a while but eventually found a way to check the zoom. Let me know if any changes are needed or if something is wrong. Thanks!
Hi there! No no, not me. First timer Just went through the PR back then and decided to say something :D
Thank you
Oh and a complex rebase is needed!
hey @benfurber , I hope all is fixed now and rebase is okay
Awesome, thank you @motuz0001!
@all-contributors add @motuz0001 for code