feat: add accordion for settings form

[benfurber]

Description

Apply this new accordion style, to the two forms (ChangeEmailForm and ChangePasswordForm) in the account settings tab (AccountSettingsSection)

Details

Obvs the new component should be built in the component library (packages/components). For bonus points, it would be a chance to start putting whole form objects into the component library.

[ceconcarlsen]

@benfurber i`ll starting working on it, thanks

[domsantini]

Hey @ceconcarlsen ! Were you still working on this issue by chance? I just learned about this project and would love to start contributing. Happy to take this off your plate if you're busy.

[benfurber]

Welcome @domsantini! :)

I'd say give @ceconcarlsen a day to get back to you. After that please do give it a go.

[domsantini]

Thanks so much @benfurber !! That sounds perfect.

[domsantini]

Thank you, Ben! I’ll work on getting this done this week.

[benfurber]

Hey @domsantini, how are you getting on?

[domsantini]

Hey @benfurber ! So sorry I haven't pushed any progress. I got something thrown on my plate and I've had to study for that. But I'm hoping to get back on this as soon as that's done.

You can unassign me for the time being if you'd like, just so someone else can come swoop the ticket.

[joperafe]

Hi there @benfurber could I work on this one?

[benfurber]

Awesome, thanks @benfurber!

[CrowsVeldt]

I'd like to take a shot at this

[benfurber]

Welcome @CrowsVeldt! Please do, the issue is yours...

[CrowsVeldt]

First revision:

I tried changing the arrow glyphs to chevrons to more closely match the example provided, but am having trouble resizing them to match.

@benfurber What do you think so far?

[benfurber]

Nice one @CrowsVeldt! Looks ready for a PR. :)

[CrowsVeldt]

I was thinking I could refactor the accordion to have child elements "above\below the fold", where children above the fold would be visible when the accordion is closed.

This could be more future-proof, for example in the event that you might need an accordion without a title or maybe with a checkbox in the 'header' to activate it.

However, if there would be no need for anything like that it would be unneeded complexity.

Do you think this might be useful?

[benfurber]

@CrowsVeldt I think there are some other bits that are more useful so I think what you've done so far is all that's needed.

Does anything else on the board that your fancy right now? If not, there should be some more UI focused issues added on Wednesday.

[CrowsVeldt]

@benfurber I'll take a look, thanks!

[onearmy-bot]

:tada: This issue has been resolved in version 2.30.0 :tada:

The release is available on GitHub release

Your semantic-release bot :package::rocket: