Search filter fixes

[mariojsnunes]

PR Checklist

• [x] - Commit messages are descriptive, it will be used in our Release Notes

PR Type

• [x] Bug fix (non-breaking change which fixes an issue)
• [ ] New feature (non-breaking change which adds functionality)
• [ ] Breaking change (fix or feature that would cause existing functionality to change)
• [ ] Developer experience (improves developer workflows for contributing to the project)

Description

1. Hides MostRelevant option when there is no search text.
2. Fixes sorting option displayed value (now always displays the label instead of the value - "Most Relevant" instead of "MostRelevant")
3. Improved typescript usage and aligned patterns of Howto/Research/Questions search

Git Issues

Closes #

[cypress[bot]]

1 flaky test on run #5530 ↗︎

0

80

1

0

1

Details:

Merge branch 'master' into fix/hide-relevant
Project: onearmy-community-platform	Commit: 97235feaba
Status: Passed	Duration: 04:16 💡
Started: May 8, 2024 1:22 PM	Ended: May 8, 2024 1:26 PM

  src/integration/profile.spec.ts • 1 flaky test • ci-chrome

View Output Video

Test		Artifacts
[Profile] > [By User] > [Can contact profiles by default]		Test Replay Screenshots Video

Review all test suite changes for PR #3478 ↗︎

[codecov[bot]]

Codecov Report

Attention: Patch coverage is 57.62712% with 25 lines in your changes are missing coverage. Please review.

Project coverage is 66.76%. Comparing base (1cfe164) to head (97235fe).

Files	Patch %	Lines
.../pages/Howto/Content/HowtoList/HowtoSortOptions.ts	0.00%	13 Missing :warning:
src/pages/Question/QuestionFilterHeader.tsx	37.50%	5 Missing :warning:
src/pages/Question/question.service.ts	33.33%	4 Missing :warning:
...ages/Howto/Content/HowtoList/HowtoFilterHeader.tsx	0.00%	1 Missing :warning:
src/pages/Howto/Content/HowtoList/HowtoList.tsx	0.00%	1 Missing :warning:
src/pages/Question/QuestionListing.tsx	66.66%	1 Missing :warning:

Additional details and impacted files

@@            Coverage Diff             @@
##           master    #3478      +/-   ##
==========================================
+ Coverage   66.71%   66.76%   +0.04%     
==========================================
  Files         428      429       +1     
  Lines       13512    13533      +21     
  Branches     2436     2442       +6     
==========================================
+ Hits         9015     9035      +20     
- Misses       4451     4452       +1     
  Partials       46       46              

:umbrella: View full report in Codecov by Sentry.
:loudspeaker: Have feedback on the report? Share it here.

[onearmy-bot]

:tada: This PR is included in version 1.178.0 :tada:

The release is available on GitHub release

Your semantic-release bot :package::rocket: